Oolite Bulletins

phkb wrote:

It's actually a pretty simple mistake, and one I often make:

Layne wrote:

system.government = 7

should read as system.government == 7. In Javascript, the "=" sign on its own is used for assigning values (ie. var x = 1;) In an "If" statement, you need to use "==" or "===". Either should do the trick.

phkb wrote:

What is the best way to determine that a ship is docking at a station? Do a check on whether dockingInstructions exists and the station property of the dockingInstructions is the desired station?

phkb wrote:

What is the best way to determine that a ship is docking at a station? Do a check on whether dockingInstructions exists and the station property of the dockingInstructions is the desired station?

Wildeblood wrote:

Don'tcha just add an otherShipDocked function to the station's ship script and use it to pass the data through to your worldscript(s)?

Smivs wrote:

I don't think it is possible to change any .plists via js.

cim wrote:

For commodities.plist - and I would also not recommend spending time working on this for a new OXP - you can define multiple market definition entries within the plist, and then in planetinfo.plist (or the JS equivalents) select different market definitions for different systems which coincidentally happen to match the economy numbers of those systems. The old  BlOomberg Markets OXP uses a very similar method to create rare temporary rises or falls in prices of single commodities in single systems.

For trade-goods.plist there are several ways to do it. In the general case, I would use the market_script key in [wiki]planetinfo.plist[/wiki] to set a global market script across all systems, and then use that script to set up whatever algorithm was desired for goods prices based on the economy.

That said, depending on how complex what you want is, you might be able to do it entirely in [wiki]trade-goods.plist[/wiki] by using the peak_export and peak_import properties. In the core game they're set to 0 and 7 (or 7 and 0) for all goods, so the prices line up between Rich Industrial and Poor Agricultural - but you could set them to something else, so a trade good has the highest quantities and lowest price at economy 3, the lowest quantities and highest price at economy 6, and everywhere else will automatically end up somewhere in the middle. You then just rename the economies in descriptions.plist so that the peak import/export you've set up makes thematic sense.

Vincentz wrote:

So... (sorry for being so code illiterate) how would a market_script.js look like, and how would it be able to differentiate from different economiy levels?

this.updateLocalCommodityDefinition = function(marketdef, station, system) {
    var systemInfo = System.infoForSystem(galaxyNumber,system); // get the system info
    var economyNumber = systemInfo.economy; // get the economy number for the system
    // you can also get other system properties or variables at this point

    // the precalculated details for the tradegood are in the marketdef object at this point
    // so you can still use the plist to set up a lot of the basic calculations, and only need
    // to adjust the result here

    var price = ...; // calculation of price based on economy
    var quantity = ...; // calculation of price based on economy

    // set the calculated price and quantity back onto the market definition
    marketdef.price = price;
    marketdef.quantity = quantity;
    // and give the market definition back to Oolite to use
    return marketdef;
};

cim wrote:

Vincentz wrote:

So... (sorry for being so code illiterate) how would a market_script.js look like, and how would it be able to differentiate from different economiy levels?

You'd set a market script on the system (through planetinfo.plist, most likely) with something like this in:

Code: Select all

this.updateLocalCommodityDefinition = function(marketdef, station, system) {
    var systemInfo = System.infoForSystem(galaxyNumber,system); // get the system info
    var economyNumber = systemInfo.economy; // get the economy number for the system
    // you can also get other system properties or variables at this point

    // the precalculated details for the tradegood are in the marketdef object at this point
    // so you can still use the plist to set up a lot of the basic calculations, and only need
    // to adjust the result here

    var price = ...; // calculation of price based on economy
    var quantity = ...; // calculation of price based on economy

    // set the calculated price and quantity back onto the market definition
    marketdef.price = price;
    marketdef.quantity = quantity;
    // and give the market definition back to Oolite to use
    return marketdef;
};