Sponateous cargo pickup

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

User avatar
Thargoid
Thargoid
Thargoid
Posts: 5528
Joined: Thu Jun 12, 2008 6:55 pm

Post by Thargoid »

I can't see how it could cause such a bug, as it doesn't have any spawning/pod introduction mechanisms of its own, and just uses the populator to add them into the game.

So I'm totally confuddled...
User avatar
Greyman
Dangerous
Dangerous
Posts: 98
Joined: Thu Jun 05, 2008 5:54 pm
Location: somewhere in the Bavarian outback

Post by Greyman »

I totally agree with JazHaz. There are far worse things that can happen in the Ooniverse than being randomly awarded 1t of whatever cargo.

But to be sure I'll start by playing without Pods OXP for a while. As I'll be a bit busy today and tomorrow this might take a while.

@Thargoid: Don't be too confuddled, I think we all rather enjoy your OXP even though it seems to disable my Fuel Soops too often :-(
Get the Oolite Keymapper for Mac here!
User avatar
Eric Walch
Slightly Grand Rear Admiral
Slightly Grand Rear Admiral
Posts: 5536
Joined: Sat Jun 16, 2007 3:48 pm
Location: Netherlands

Post by Eric Walch »

JazHaz wrote:
Greyman wrote:
So does this hint to some problem with the Pods 1.10.OXP (an OXP which I really enjoy very much)?
Well I for one won't be uninstalling it, as the bug doesn't spoil much for me! I like the features very much, even when I scoop an exploding pod (happened last night for the first time)!
When you like pods, you probably also like: Cargo_Wreck_Teaser.OXP.
The exploding pod you mention, suggest it is one from pods.oxp. But I agree with thargoid that it is not likely that oxp that is causing it, but more an oxp that is spawning cargopods in front of your ship. However, from the mentioned list there is no one that rings any bells with me. Most of them I also have installed but I never had the cargo pick-up.
User avatar
Kaks
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 3009
Joined: Mon Jan 21, 2008 11:41 pm
Location: The Big Smoke

Post by Kaks »

Found the problem! What I found is inside Pods.oxp: I'm going to use one of the scripts for illustration purposes:

All other scripts in that oxp seem ok, but this one isn't:

Code: Select all

this.name				= "pods_trumblepod";
this.author				= "Thargoid";
this.copyright			= "Creative Commons: attribution, non-commercial, sharealike.";
this.description			= "Script for a pod with a trumble in it. OK so I succumbed ;) ";
this.version			= "1.3";

this.shipWasScooped = function(scooper)
	{
	if(scooper.isPlayer && missionVariables.novacount && player.ship.hasEquipment("EQ_TRUMBLE"))
		{
		player.consoleMessage("Pod contains a few scraps of food, and ... Oh no! A trumble!",6);
		player.ship.awardEquipment("EQ_TRUMBLE")
		}
	else
		{
		let cargo = expandDescription('[pod_content_tons]')
		if(player.ship.canAwardCargo(cargo, 1))
			{ 
			player.consoleMessage("1 ton " + cargo,6);
			player.ship.awardCargo(cargo, 1);
			}
		}
	}
The else doesn't check if scooper.isPlayer!

A quick & painless fix:

Code: Select all

this.name				= "pods_trumblepod";
this.author				= "Thargoid";
this.copyright			= "Creative Commons: attribution, non-commercial, sharealike.";
this.description			= "Script for a pod with a trumble in it. OK so I succumbed ;) ";
this.version			= "1.3.1";

this.shipWasScooped = function(scooper)
	{
	if (!scooper.isPlayer) return;

	if(missionVariables.novacount && !player.ship.hasEquipment("EQ_TRUMBLE"))
		{
		player.consoleMessage("Pod contains a few scraps of food, and ... Oh no! A trumble!",6);
		player.ship.awardEquipment("EQ_TRUMBLE")
		}
	else
		{
		let cargo = expandDescription('[pod_content_tons]')
		if(player.ship.canAwardCargo(cargo, 1))
			{ 
			player.consoleMessage("1 ton " + cargo,6);
			player.ship.awardCargo(cargo, 1);
			}
		}
	}
PS: I also noticed that 1.3 tries to award a trumble if the player had already a trumble: shome mishtake, shurely... I've re-edited my fix to only award a trumble if the player hasn't got one already! :)
Last edited by Kaks on Thu Dec 31, 2009 8:11 pm, edited 1 time in total.
Hey, free OXPs: farsun v1.05 & tty v0.5! :0)
User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 16081
Joined: Sat Jul 04, 2009 9:31 pm
Location: The Lizard's Claw
Contact:

Post by Cody »

Kaks wrote:
award a trumble
I love that line... what a joyous award.

Got to hand it to you guys... even on New Year's Eve you're sorting stuff out.

Happy New Year.
I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
User avatar
Kaks
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 3009
Joined: Mon Jan 21, 2008 11:41 pm
Location: The Big Smoke

Post by Kaks »

Doh! I knew I'd forgotten something today! :)
Ok, new year resolution: life, I should be getting one. That said, I'm probably going to be gone for a few days... :D

Happy new year peeps! :P
Hey, free OXPs: farsun v1.05 & tty v0.5! :0)
User avatar
Thargoid
Thargoid
Thargoid
Posts: 5528
Joined: Thu Jun 12, 2008 6:55 pm

Post by Thargoid »

Hmm, so obvious I didn't see it :oops: It would be the damn trumble pod wouldn't it! I bet they snuck in and reprogrammed the thing...

Anyway updated versions of both are now on box.net. I've also adjusted the role probabilities on some of them, to keep people happy ;)
User avatar
Greyman
Dangerous
Dangerous
Posts: 98
Joined: Thu Jun 05, 2008 5:54 pm
Location: somewhere in the Bavarian outback

Post by Greyman »

Thank you for the help!

Happy New Year to everyone.
Get the Oolite Keymapper for Mac here!
BlackKnight
Dangerous
Dangerous
Posts: 70
Joined: Thu May 15, 2008 5:45 pm

Post by BlackKnight »

Thargoid wrote:


Anyway updated versions of both are now on box.net. I've also adjusted the role probabilities on some of them, to keep people happy ;)
Great, thank you - and on New Years' Eve, too! Now if you could fix it for me to find a personality (and I don't mean Captain Hesperus :shock: ) or a young lady in a tight spacesuit in a pod, my life would be complete :lol:
You really want to know what's gonna happen, Ambassador? Boom. Boom boom. Boom, boom, boom, boom, boom. BOOM!
User avatar
JazHaz
---- E L I T E ----
---- E L I T E ----
Posts: 2991
Joined: Tue Sep 22, 2009 11:07 am
Location: Enfield, Middlesex
Contact:

Post by JazHaz »

Thargoid wrote:
Anyway updated versions of both are now on box.net. I've also adjusted the role probabilities on some of them, to keep people happy ;)
YAY! Happy Hootenanny!

Thanks for the new version! Although not looking forward to receiving a Trumble, thought I had avoided the buggers! :)
JazHaz

Gimi wrote:
drew wrote:
£4,500 though! :shock: <Faints>
Cheers,
Drew.
Maybe you could start a Kickstarter Campaign to found your £4500 pledge. 8)
Thanks to Gimi, I got an eBook in my inbox tonight (31st May 2014 - Release of Elite Reclamation)!
User avatar
DaddyHoggy
Intergalactic Spam Assassin
Intergalactic Spam Assassin
Posts: 8515
Joined: Tue Dec 05, 2006 9:43 pm
Location: Newbury, UK
Contact:

Post by DaddyHoggy »

BlackKnight wrote:
Thargoid wrote:


Anyway updated versions of both are now on box.net. I've also adjusted the role probabilities on some of them, to keep people happy ;)
Great, thank you - and on New Years' Eve, too! Now if you could fix it for me to find a personality (and I don't mean Captain Hesperus :shock: ) or a young lady in a tight spacesuit in a pod, my life would be complete :lol:
Happy New Year... Image
Selezen wrote:
Apparently I was having a DaddyHoggy moment.
Oolite Life is now revealed here
Post Reply