Sponateous cargo pickup

Wiki pages · Post by **Thargoid** » Thu Dec 31, 2009 2:53 pm

I can't see how it could cause such a bug, as it doesn't have any spawning/pod introduction mechanisms of its own, and just uses the populator to add them into the game.

So I'm totally confuddled...

Greyman · Post by **Greyman** » Thu Dec 31, 2009 2:57 pm

I totally agree with JazHaz. There are far worse things that can happen in the Ooniverse than being randomly awarded 1t of whatever cargo.

But to be sure I'll start by playing without Pods OXP for a while. As I'll be a bit busy today and tomorrow this might take a while.

@Thargoid: Don't be too confuddled, I think we all rather enjoy your OXP even though it seems to disable my Fuel Soops too often

Post by **Eric Walch** » Thu Dec 31, 2009 3:11 pm

JazHaz wrote:
Greyman wrote:
So does this hint to some problem with the Pods 1.10.OXP (an OXP which I really enjoy very much)?
Well I for one won't be uninstalling it, as the bug doesn't spoil much for me! I like the features very much, even when I scoop an exploding pod (happened last night for the first time)!

When you like pods, you probably also like: Cargo_Wreck_Teaser.OXP.
The exploding pod you mention, suggest it is one from pods.oxp. But I agree with thargoid that it is not likely that oxp that is causing it, but more an oxp that is spawning cargopods in front of your ship. However, from the mentioned list there is no one that rings any bells with me. Most of them I also have installed but I never had the cargo pick-up.

Post by **Kaks** » Thu Dec 31, 2009 7:42 pm

Found the problem! What I found is inside Pods.oxp: ~~I'm going to use one of the scripts for illustration purposes:~~

All other scripts in that oxp seem ok, but this one isn't:

Code: Select all

this.name				= "pods_trumblepod";
this.author				= "Thargoid";
this.copyright			= "Creative Commons: attribution, non-commercial, sharealike.";
this.description			= "Script for a pod with a trumble in it. OK so I succumbed ;) ";
this.version			= "1.3";

this.shipWasScooped = function(scooper)
	{
	if(scooper.isPlayer && missionVariables.novacount && player.ship.hasEquipment("EQ_TRUMBLE"))
		{
		player.consoleMessage("Pod contains a few scraps of food, and ... Oh no! A trumble!",6);
		player.ship.awardEquipment("EQ_TRUMBLE")
		}
	else
		{
		let cargo = expandDescription('[pod_content_tons]')
		if(player.ship.canAwardCargo(cargo, 1))
			{ 
			player.consoleMessage("1 ton " + cargo,6);
			player.ship.awardCargo(cargo, 1);
			}
		}
	}

The else doesn't check if scooper.isPlayer!

A quick & painless fix:

Code: Select all

this.name				= "pods_trumblepod";
this.author				= "Thargoid";
this.copyright			= "Creative Commons: attribution, non-commercial, sharealike.";
this.description			= "Script for a pod with a trumble in it. OK so I succumbed ;) ";
this.version			= "1.3.1";

this.shipWasScooped = function(scooper)
	{
	if (!scooper.isPlayer) return;

	if(missionVariables.novacount && !player.ship.hasEquipment("EQ_TRUMBLE"))
		{
		player.consoleMessage("Pod contains a few scraps of food, and ... Oh no! A trumble!",6);
		player.ship.awardEquipment("EQ_TRUMBLE")
		}
	else
		{
		let cargo = expandDescription('[pod_content_tons]')
		if(player.ship.canAwardCargo(cargo, 1))
			{ 
			player.consoleMessage("1 ton " + cargo,6);
			player.ship.awardCargo(cargo, 1);
			}
		}
	}

PS: I also noticed that 1.3 tries to award a trumble if the player had already a trumble: shome mishtake, shurely... I've re-edited my fix to only award a trumble if the player hasn't got one already!

Website · Post by **Cody** » Thu Dec 31, 2009 7:54 pm

Kaks wrote:
award a trumble

I love that line... what a joyous award.

Got to hand it to you guys... even on New Year's Eve you're sorting stuff out.

Happy New Year.

Post by **Kaks** » Thu Dec 31, 2009 8:09 pm

Doh! I knew I'd forgotten something today!

Ok, new year resolution: life, I should be getting one. That said, I'm probably going to be gone for a few days...

Happy new year peeps!

Wiki pages · Post by **Thargoid** » Thu Dec 31, 2009 8:10 pm

Hmm, so obvious I didn't see it

It would be the damn trumble pod wouldn't it! I bet they snuck in and reprogrammed the thing...

Anyway updated versions of both are now on box.net. I've also adjusted the role probabilities on some of them, to keep people happy

Greyman · Post by **Greyman** » Thu Dec 31, 2009 8:56 pm

Thank you for the help!

Happy New Year to everyone.

BlackKnight · Post by **BlackKnight** » Thu Dec 31, 2009 11:09 pm

Thargoid wrote:

Anyway updated versions of both are now on box.net. I've also adjusted the role probabilities on some of them, to keep people happy

Great, thank you - and on New Years' Eve, too! Now if you could fix it for me to find a personality (and I don't mean Captain Hesperus

) or a young lady in a tight spacesuit in a pod, my life would be complete

JazHaz · Post by **JazHaz** » Fri Jan 01, 2010 1:05 am

Thargoid wrote:
Anyway updated versions of both are now on box.net. I've also adjusted the role probabilities on some of them, to keep people happy

YAY! Happy Hootenanny!

Thanks for the new version! Although not looking forward to receiving a Trumble, thought I had avoided the buggers!

Website · Post by **DaddyHoggy** » Fri Jan 01, 2010 10:37 pm

BlackKnight wrote:
Thargoid wrote:

Anyway updated versions of both are now on box.net. I've also adjusted the role probabilities on some of them, to keep people happy
Great, thank you - and on New Years' Eve, too! Now if you could fix it for me to find a personality (and I don't mean Captain Hesperus ) or a young lady in a tight spacesuit in a pod, my life would be complete

Happy New Year...