OXP-ers, check this out: 277 verify-OXP logs x3

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

Post Reply
Chaky
Deadly
Deadly
Posts: 213
Joined: Sat Aug 15, 2009 6:15 am

OXP-ers, check this out: 277 verify-OXP logs x3

Post by Chaky »

Here're a bunch of Verify-OXP logs... They are generated by Oolite 1.73.4, trunk 2722 (latest by Dizzy) and trunk 2748 (latest nightly build). , side-by-side (if you tilt your head 90°, that is)

http://www.box.net/shared/r5ifpuq5if

I've separated them roughly by OXP genre. That is pretty much everything that I managed to download (except OSE).

All OXP are "out-of-the-box" condition, and updated to the best of my knowledge.

Might give you some insight of what to fix in your OXPs.
Last edited by Chaky on Sun Nov 15, 2009 1:11 pm, edited 3 times in total.
User avatar
Thargoid
Thargoid
Thargoid
Posts: 5528
Joined: Thu Jun 12, 2008 6:55 pm

Post by Thargoid »

Sadly I think many of the logs (especially the trunk ones) are more showing the deficiencies in oxp-verifier than in the oxps.

Also any reason for 7zip'ing them? They're small files anyway as .logs.
User avatar
Kaks
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 3009
Joined: Mon Jan 21, 2008 11:41 pm
Location: The Big Smoke

Post by Kaks »

Still, good to have in order to find out what's broken n the trunk verifier! :)

From dictators 1.3, I see there's a few misspelled properties ('has escape_pod' instead of 'has_escape_pod' for example) even though it shouldn't flag up escort_ship in trunk (it's a valid 'alternate' spelling in trunk now, but it's not a valid key in 1.73.4 [escort-ship is the 'traditional' spelling]) - Chaky, have you got the latest trunk version?

PS: Chaky, if you want to make that lot ultra-convenient for everybody, just bundle all the separate log files inside a single .zip file - one click grabs everything, the difference in compression ratio between .7z & .zip is minimal in this case, and it saves some people the trouble of finding and downloading a 7zip program for their computer...
Hey, free OXPs: farsun v1.05 & tty v0.5! :0)
Chaky
Deadly
Deadly
Posts: 213
Joined: Sat Aug 15, 2009 6:15 am

Post by Chaky »

The trunk is "almost" the latest. (Nightly build)

I Just downloaded 2740, so, I'll do the checks again.. this time separated.
User avatar
Eric Walch
Slightly Grand Rear Admiral
Slightly Grand Rear Admiral
Posts: 5536
Joined: Sat Jun 16, 2007 3:48 pm
Location: Netherlands

Post by Eric Walch »

Thargoid wrote:
Sadly I think many of the logs (especially the trunk ones) are more showing the deficiencies in oxp-verifier than in the oxps.
A lot of the reports of missing keys is because the ships are like_shiped with other ships outside of the oxp. Like the references of all buoys in commies which are copies of oolites internal buoys.

e.g. in:

Code: Select all

Checking shipdata.plist
  Ship "buzzer-base":
    ----- WARNING: unknown key "is_template".
    ***** ERROR: verification of ship "buzzer-base" failed at "root": Required keys (name, roles) missing from dictionary.
is_template means that the entry does not need to have a name or role.

And like others noted 7zip is not a friendly format. Some time ago i managed to find a unzipper for it on the mac, but that uses some kind of command-line interface. No problem when you are a regular user but a pain when you use it only once or twice a year.

And I notice a lot of warnings of readMe files inside the oxp. It is the wrong place to put them but in my experience a lot of oxp's are redistributed with missing documentation. And because the filesize is so small I always add them twice. One at the correct place and one inside the oxp as backup.
Chaky
Deadly
Deadly
Posts: 213
Joined: Sat Aug 15, 2009 6:15 am

Post by Chaky »

Never thought that ppl will have troubles opening 7z files..
I'll reupload uncompressed files for now..

Will use zip in future. (Or should I use tarball?)

Edit: Done..
.. now back to rewriting the code so it would merge the logs according to options.
Chaky
Deadly
Deadly
Posts: 213
Joined: Sat Aug 15, 2009 6:15 am

Post by Chaky »

Finally... working.

I'll be uploading zipped logs, grouped by genre, as well as all logs in one pile (subfolder).

All the OXPs are untouched, except for removal of "junk files" and readmes, to lessen the clutter, and filter out the important stuff. Too bad the scripts aren't checked.

OXPs are checked by Oolite 1.73.4, trunk 2722 (latest by Dizzy) and trunk 2748 (latest nightly build).

Each log is actually merger of 3 different logs, each by different Oolite version.
Chaky
Deadly
Deadly
Posts: 213
Joined: Sat Aug 15, 2009 6:15 am

Post by Chaky »

Done and ready for scrutiny.

Let me know if I missed any updates.
User avatar
Svengali
Commander
Commander
Posts: 2370
Joined: Sat Oct 20, 2007 2:52 pm

Post by Svengali »

Hey! Nice collection. Good job, man.
Post Reply