Multiple Log-files?

An area for discussing new ideas and additions to Oolite.

Moderators: winston, another_commander

Post Reply
User avatar
Diziet Sma
---- E L I T E ----
---- E L I T E ----
Posts: 6312
Joined: Mon Apr 06, 2009 12:20 pm
Location: Aboard the Pitviper S.E. "Blackwidow"

Multiple Log-files?

Post by Diziet Sma »

Whilst reading a recent post, I noticed once again something that happens regularly with bug reports.. Oolite had been restarted a number of times since the bug occurred, and therefore no relevant log was available for inspection.

Therefore, I would like to propose that Oolite save more than just the last 2 logs.. maybe it would be advisable to keep the last 5 or 6 logs instead...

Opinions?
Most games have some sort of paddling-pool-and-water-wings beginning to ease you in: Oolite takes the rather more Darwinian approach of heaving you straight into the ocean, often with a brick or two in your pockets for luck. ~ Disembodied
Screet
---- E L I T E ----
---- E L I T E ----
Posts: 1883
Joined: Wed Dec 10, 2008 3:02 am
Location: Bremen, Germany

Re: Multiple Log-files?

Post by Screet »

Diziet Sma wrote:
Whilst reading a recent post, I noticed once again something that happens regularly with bug reports.. Oolite had been restarted a number of times since the bug occurred, and therefore no relevant log was available for inspection.

Therefore, I would like to propose that Oolite save more than just the last 2 logs.. maybe it would be advisable to keep the last 5 or 6 logs instead...

Opinions?
Sounds good, although Kaks did find the line - it surely would help with a lot of things. If upon renaming of the previous log also stderr could be copied into the log so that both infos would be available from that backup-log, it could even be better.

Maybe something additional could help: oolite writes to the log a final entry that it was properly shut down (alternative: somewhere else). If that log is renamed upon the next start, oolite could look for that entry and if it's not there notify the user that this specific log might contain helpful information about the problem and thus should be attached to a bug report.

Screet
User avatar
Diziet Sma
---- E L I T E ----
---- E L I T E ----
Posts: 6312
Joined: Mon Apr 06, 2009 12:20 pm
Location: Aboard the Pitviper S.E. "Blackwidow"

Re: Multiple Log-files?

Post by Diziet Sma »

Screet wrote:
Sounds good, although Kaks did find the line
Yep, thanks to a screenshot.. otherwise, it would have been yet another of those hard-to-track-down bugs we're all so fond of.. :lol:
Most games have some sort of paddling-pool-and-water-wings beginning to ease you in: Oolite takes the rather more Darwinian approach of heaving you straight into the ocean, often with a brick or two in your pockets for luck. ~ Disembodied
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6683
Joined: Wed Feb 28, 2007 7:54 am

Re: Multiple Log-files?

Post by another_commander »

Diziet Sma wrote:
Screet wrote:
Sounds good, although Kaks did find the line
Yep, thanks to a screenshot.. otherwise, it would have been yet another of those hard-to-track-down bugs we're all so fond of.. :lol:
Actually, this is incorect. Together with the assertion failed message, the game - in this case at least - writes to the log:

Code: Select all

Internal Error - WH_SCANINFO_NONE reached in [PlayerEntity updateTargeting:]
This is one of the cases where the programmers have predicted a possible scenario for failure and for this reason you get a) The assertion fail window showing you where it went wrong and b) A message in the log just before quitting.
User avatar
Diziet Sma
---- E L I T E ----
---- E L I T E ----
Posts: 6312
Joined: Mon Apr 06, 2009 12:20 pm
Location: Aboard the Pitviper S.E. "Blackwidow"

Post by Diziet Sma »

Agreed.. but in the case I referred to, the logs had already been overwritten, so it was only the screenshot that indicated the problem.. had it not been for the screenshot, there would have been no evidence.. hence my suggestion for keeping more than the last 2 logs.
Most games have some sort of paddling-pool-and-water-wings beginning to ease you in: Oolite takes the rather more Darwinian approach of heaving you straight into the ocean, often with a brick or two in your pockets for luck. ~ Disembodied
User avatar
Diziet Sma
---- E L I T E ----
---- E L I T E ----
Posts: 6312
Joined: Mon Apr 06, 2009 12:20 pm
Location: Aboard the Pitviper S.E. "Blackwidow"

Re: Multiple Log-files?

Post by Diziet Sma »

Screet wrote:
Maybe something additional could help: oolite writes to the log a final entry that it was properly shut down (alternative: somewhere else). If that log is renamed upon the next start, oolite could look for that entry and if it's not there notify the user that this specific log might contain helpful information about the problem and thus should be attached to a bug report.

Screet
I like the sound of this idea too..
Most games have some sort of paddling-pool-and-water-wings beginning to ease you in: Oolite takes the rather more Darwinian approach of heaving you straight into the ocean, often with a brick or two in your pockets for luck. ~ Disembodied
Post Reply