Deprecations

[Lestradae]

Quick question,

found out that "setStateMachine:" in AI's is deprecated in trunk.

So for the sake of future compatibility, how do I have to alter code like:

""NOTHING_FOUND" = ("setStateMachine: BlablaAI.plist");"

... so that it does stay valid in future Oolite?

I did read in the wiki about it before anyone asks, but did not find an answer conclusive enough for my tastes

Also something I don't understand how to alter is "Entity.setOrientation() is deprecated, use entity.orientation = foo instead."

Can someone give me an example of "before" and "after"?

Grateful for eventual explanation

L

[Cmd. Cheyd]

Also something I don't understand how to alter is "Entity.setOrientation() is deprecated, use entity.orientation = foo instead."

Can someone give me an example of "before" and "after"?

I am by NO MEANS an authority, as I'm still working on my first OXP. But, I think the before would be:

Code: Select all

Entity.SetOrientation (w x y z);

The new/after method would be:

Code: Select all

entity.orientation = w x y z;

Is that what you're asking?

[Frame]

setStateMachine is obselete as you can directly set the state like this

ship.AIState ="BlablaAI.plist"

sry i meant

ship.AIState ="A_STATE_IN_THE_PLIST_FILE"

regarding orientation, it is the same deal

ship.orientation = ([1,0,0,0])

or

ship.orientation = (quaternion)

likewise for position and setPosition

ship.position = ([x,y,z])

or

ship.position =(vector)

remember the brackets[], when modifying the elements of the quaternions or vectors...

cheers Frame....

[Lestradae]

Thanks guys, very helpful, all clear now

[Thargoid]

This may be a dumb question (as I never new setStateMachine: existed before this thread), but how does setStateMachine: differ from setAITo: ?

Personally I would normally use setAITo: or switchAITo: to move from one AI to another, depending on whether it should be temporary or permanent.

Oh and ship.AIState= is a JS command not an AI one (you want setStateTo: to do that kind of switch within an AI).

[Frame]

regarding setStateMachine.. sorry I misread... I blame tireness.. early bird these days so early tired..

you are trying to start something from within the AI.plist..

you should send a scriptmessage instead.. but it is all in the wiki
or look at bouy repair, early versions, it used sendscriptmessage.

I never actually used setStateMachine, I think I tried, but gave up, and used setAIto or switchAI as thargoid wrote...

[Svengali]

you should send a scriptmessage instead..

No. It takes processingtime and should only be used if additional checks are necessary. For a simple replacement of 'setStateMachine' better use the AI methods.

[Eric Walch]

This may be a dumb question (as I never new setStateMachine: existed before this thread), but how does setStateMachine: differ from setAITo: ?

It doesn't, they are identical. setStateMachine was never mend to be used in AI, although even 1.65 abusively still used it in some of its own AI's. Every case of setStateMachine can be replaced by setAITo.

But with the new white-listing we probably should link it to setAITo, so also old and wrong code will run?

[Lestradae]

So the safest method to re-precate (I hope Ahruman doesn't read that word) would be to exchange ...

Code: Select all

setStateMachine: BlablaAI.plist

... with ...

Code: Select all

setAITo: BlablaAI.plist

... correct?



L

[Eric Walch]

Code: Select all

setAITo: BlablaAI.plist

... correct?



L

Yes.

Somehow that setStatemachine slipped into the Oolite escortAI. Only fixed around 1.70. It is the internal name of the machine that sets the AI states. setAITo calls the same internal function but was mend for public use.
But because it was in an old Oolite file and there are probably a lot escortAI modifications around, it is likely there are a lot oxp's around with this problem. On the whitelist we can relay these old names to legal ones. This way they will keep working.

[Thargoid]

It's also in the wiki in a few places, via the same route.

[Lestradae]

On the whitelist we can relay these old names to legal ones. This way they will keep working.

That would be useful info for me if it was done - I have found quite a few setStatemachine switches in OSE's inherited AI's, I was about to change them all to, well, looks like setAITo, but if this stuff is whitelisted I can spare me that work.

Could you please tell me if and when a decision is taken on this?



L

[Eric Walch]

[Could you please tell me if and when a decision is taken on this?
L

I just added it as revision 2296 because it was long part of Oolites own AI set.

[Lestradae]

That was quick, very fine! You just spared me an afternoon of tedious copy&paste activity

[Thargoid]

Are depreciations normally listed in the OXP verifier (-verify-oxp optional command line tags)? Just tried to verify a couple of OXPs that I know will need some update for the setPosition/setOrientation changes, and they didn't show.

Is it not something that's supported, or is it just because it's using a trunk compilation rather than a release test version?