max_missiles=36

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

Post Reply
metri
Above Average
Above Average
Posts: 26
Joined: Sat Feb 14, 2009 9:01 pm

max_missiles=36

Post by metri »

Having max_missiles greater than 18 causes strange effects and can segfault oolite.
User avatar
JensAyton
Grand Admiral Emeritus
Grand Admiral Emeritus
Posts: 6657
Joined: Sat Apr 02, 2005 2:43 pm
Location: Sweden
Contact:

Post by JensAyton »

This was fixed in test release 1.71 (specifically, r1283). Are you using Oolite 1.65? If so, crash reports are essentially meaningless since the game has changed a lot since then. (Test releases are available here.)

Incidentally, the limit is actually 16. :-)
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6633
Joined: Wed Feb 28, 2007 7:54 am

Post by another_commander »

I think I have located a possible cause for the problem. What I need now is a reliable way to reproduce it. Do I just set a value greater than 16 in shipdata.plist for any ship? Or in a savegame? In the second case, do you happen to have any such savegame available?
metri
Above Average
Above Average
Posts: 26
Joined: Sat Feb 14, 2009 9:01 pm

Post by metri »

Using trunk version, I'm editing shipdata.plist and after that loading old savegame.
Using 20 for max missiles will make it apper to be 16.
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6633
Joined: Wed Feb 28, 2007 7:54 am

Post by another_commander »

metri wrote:
Using 20 for max missiles will make it apper to be 16.
Well, that's the expected behaviour. You can have a maximum of 16 missiles so that's OK. I was more concerned with the crash scenario.
metri
Above Average
Above Average
Posts: 26
Joined: Sat Feb 14, 2009 9:01 pm

Post by metri »

Try with max_missiles=36
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6633
Joined: Wed Feb 28, 2007 7:54 am

Post by another_commander »

OK, resolved. Commiting shortly to SVN. Thanks for bringing it to our attention.
User avatar
ClymAngus
---- E L I T E ----
---- E L I T E ----
Posts: 2508
Joined: Tue Jul 08, 2008 12:31 am
Location: London England
Contact:

Post by ClymAngus »

36 max missiles? I envisage a ship built around one of these:
Image
Post Reply