Changing Oolite...
Moderators: winston, another_commander
- hiran
- Theorethicist
- Posts: 2403
- Joined: Fri Mar 26, 2021 1:39 pm
- Location: a parallel world I created for myself. Some call it a singularity...
Changing Oolite...
How do changes to Oolite actually get processed?
Does one have to open a thread to discuss it? Does one raise a pull request against the source repository?
I found a small glitch on the Oolite.desktop file for Unix UIs and want to feed a fix for it.
Does one have to open a thread to discuss it? Does one raise a pull request against the source repository?
I found a small glitch on the Oolite.desktop file for Unix UIs and want to feed a fix for it.
Sunshine - Moonlight - Good Times - Oolite
Re: Changing Oolite...
I think for smaller things or fixes like this, you can just do a pull request or open an issue here. There, you can then discuss the proposed changes. You probably need to change one of these two files (though I am not 100% sure):
installers/FreeDesktop/oolite.desktop
installers/posix/setup.body
installers/FreeDesktop/oolite.desktop
installers/posix/setup.body
- hiran
- Theorethicist
- Posts: 2403
- Joined: Fri Mar 26, 2021 1:39 pm
- Location: a parallel world I created for myself. Some call it a singularity...
Re: Changing Oolite...
Has happened: https://github.com/OoliteProject/oolite/pull/396tsoj wrote: ↑Tue Dec 28, 2021 12:48 pmI think for smaller things or fixes like this, you can just do a pull request or open an issue here. There, you can then discuss the proposed changes. You probably need to change one of these two files (though I am not 100% sure):
installers/FreeDesktop/oolite.desktop
installers/posix/setup.body
Sunshine - Moonlight - Good Times - Oolite
-
- Quite Grand Sub-Admiral
- Posts: 6681
- Joined: Wed Feb 28, 2007 7:54 am
Re: Changing Oolite...
hiran's PR needs someone with Linux access to verify that it works, preferably across multiple distros. I guess this is why it has not been merged yet.
- Cody
- Sharp Shooter Spam Assassin
- Posts: 16081
- Joined: Sat Jul 04, 2009 9:31 pm
- Location: The Lizard's Claw
- Contact:
Re: Changing Oolite...
Didn't Getafix have something like ten distros on his machine?
I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
And any survivors, their debts I will certainly pay. There's always a way!
- hiran
- Theorethicist
- Posts: 2403
- Joined: Fri Mar 26, 2021 1:39 pm
- Location: a parallel world I created for myself. Some call it a singularity...
Re: Changing Oolite...
I created it on Ubuntu 20 LTS, and meanwhile tsoj confirmed it would also improve Manjaro Gnome. that already are two environments, but both based on Gnome.another_commander wrote: ↑Tue Dec 28, 2021 6:34 pmhiran's PR needs someone with Linux access to verify that it works, preferably across multiple distros. I guess this is why it has not been merged yet.
BTW, the change I performed is based on https://specifications.freedesktop.org/ ... 01s06.html - that means any freedesktop.org compliant environment should understand it the same way.
Sunshine - Moonlight - Good Times - Oolite
-
- Quite Grand Sub-Admiral
- Posts: 6681
- Joined: Wed Feb 28, 2007 7:54 am
Re: Changing Oolite...
If this is confirmed as working on at least two distros I could approve it, but you will have to keep monitoring the pull request or the issues section on github for any potential bugs that may be reported as a result of its merging - those will be normally yours to handle. I am away from my PC for the moment though, so I will do the merge once I am back.
- hiran
- Theorethicist
- Posts: 2403
- Joined: Fri Mar 26, 2021 1:39 pm
- Location: a parallel world I created for myself. Some call it a singularity...
Re: Changing Oolite...
I'll have a peek on this anyway. As soon as this change goes to release builds I will be impacted as well and can remove my workaround in installation scripts.another_commander wrote: ↑Wed Dec 29, 2021 12:12 pmIf this is confirmed as working on at least two distros I could approve it, but you will have to keep monitoring the pull request or the issues section on github for any potential bugs that may be reported as a result of its merging - those will be normally yours to handle. I am away from my PC for the moment though, so I will do the merge once I am back.
Sunshine - Moonlight - Good Times - Oolite
- hiran
- Theorethicist
- Posts: 2403
- Joined: Fri Mar 26, 2021 1:39 pm
- Location: a parallel world I created for myself. Some call it a singularity...
Re: Changing Oolite...
Thank you for merging. I noticed this a few days ago. Now I am wondering about the release build.another_commander wrote: ↑Wed Dec 29, 2021 12:12 pmI am away from my PC for the moment though, so I will do the merge once I am back.
What I understood is the next release will be 1.92, and it will not only have my changes. So far so good.
But then I am looking at Oolite/nightlies, and it seems we are looking at nightly builds performed somewhere in the polar region where one day/one night takes half a year each?
Sunshine - Moonlight - Good Times - Oolite
-
- Quite Grand Sub-Admiral
- Posts: 6681
- Joined: Wed Feb 28, 2007 7:54 am
Re: Changing Oolite...
The server generating the nightly builds is not running anymore. As a result, nightly builds are no longer generated.hiran wrote: ↑Tue Jan 04, 2022 8:00 pmBut then I am looking at Oolite/nightlies, and it seems we are looking at nightly builds performed somewhere in the polar region where one day/one night takes half a year each?
- Cody
- Sharp Shooter Spam Assassin
- Posts: 16081
- Joined: Sat Jul 04, 2009 9:31 pm
- Location: The Lizard's Claw
- Contact:
Re: Changing Oolite...
Once upon a time, when development was in full-swing, they were literally nightly!
I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
And any survivors, their debts I will certainly pay. There's always a way!
- hiran
- Theorethicist
- Posts: 2403
- Joined: Fri Mar 26, 2021 1:39 pm
- Location: a parallel world I created for myself. Some call it a singularity...
Re: Changing Oolite...
...and then there is a poor chap having to stay up every other night so a build gets done.another_commander wrote: ↑Tue Jan 04, 2022 8:06 pmThe server generating the nightly builds is not running anymore. As a result, nightly builds are no longer generated.hiran wrote: ↑Tue Jan 04, 2022 8:00 pmBut then I am looking at Oolite/nightlies, and it seems we are looking at nightly builds performed somewhere in the polar region where one day/one night takes half a year each?
Could Github Actions help? Although I have no clue whether they would be free to use for an FOSS project like Oolite.
Ha! They mention the 'pay as you go pricing' and state for public repositories it is free. And Oolite is public!
Sunshine - Moonlight - Good Times - Oolite
-
- Quite Grand Sub-Admiral
- Posts: 6681
- Joined: Wed Feb 28, 2007 7:54 am
Re: Changing Oolite...
Github Actions would probably be the best (and probably also the only) bet. At least Linux nightlies should be possible with it, but someone will have to set up all the necessary scripts.
- hiran
- Theorethicist
- Posts: 2403
- Joined: Fri Mar 26, 2021 1:39 pm
- Location: a parallel world I created for myself. Some call it a singularity...
Re: Changing Oolite...
I could setup such scripts but will definitely need support from people familar with the builds.another_commander wrote: ↑Tue Jan 04, 2022 8:24 pmGithub Actions would probably be the best (and probably also the only) bet. At least Linux nightlies should be possible with it, but someone will have to set up all the necessary scripts.
IIRC, phkb mastered a linux build recently. Also Commander X had a home built version.
That still leaves MacOS and Windows in the dark.
But it would be a start, better than nothing.
Seems like I finally arrived at https://bb.oolite.space/viewtopic.php?p=275467#p275467
Sunshine - Moonlight - Good Times - Oolite
- hiran
- Theorethicist
- Posts: 2403
- Joined: Fri Mar 26, 2021 1:39 pm
- Location: a parallel world I created for myself. Some call it a singularity...
Re: Changing Oolite...
So here is a pull request with Github Actions that trigger on the three operating systems. You can see them in action here.another_commander wrote: ↑Tue Jan 04, 2022 8:24 pmGithub Actions would probably be the best (and probably also the only) bet. At least Linux nightlies should be possible with it, but someone will have to set up all the necessary scripts.
I need help to refine them so they can actually perform successful builds.
Sunshine - Moonlight - Good Times - Oolite