[Solved] acceptDockingRequestFrom method not called with the sleep inducer enabled?

[Day]

Hello everybody,

I'm currently playing with the ability to refuse docking to pilots: http://wiki.alioth.net/index.php/Oolite ... equestFrom

This works well when using the Docking Computer ('c'), but doesn't work when using the "hypnotic sleep inducer" ('C') (which means I can't dock with 'c', and CAN dock with 'C'; I should never be able to dock).

From the logs I've put in my code, it seems that the acceptDockingRequestFrom method isn't called at all with 'C'.

Is this by design, or am I missing something?

PS: currently on 1.89, commit 5cbf9c85e8341b6048e1095aefd13eea20e9f694

[another_commander]

Can you please post a minimal OXP that demonstrates the issue?

[Day]

Can you please post a minimal OXP that demonstrates the issue?

Yes

[Day]

Here it is: https://github.com/DaymareOn/Diplomacy/ ... .Proof.oxz

How to test:
- install the oxz,
- exit your station from a savegame,
- try to enter it with 'c', it's refused as expected,
- try to enter it with 'C', it's accepted as NOT expected.

[another_commander]

Thanks for the test case. This looks like a bug. We should have a fix in commit 9f3c9f2. Please test and let us know if there are any problems or unforseen side effects.

[Day]

Thanks for the test case. This looks like a bug. We should have a fix in commit 9f3c9f2. Please test and let us know if there are any problems or unforseen side effects.

Tested and working

No side effects seen yet, I'll tell you if I find some.

Edit: and of course, lots of thanks