[Release] Navigation MFD

[Cody]

Thanks, cim - I should've posted that in the Bugs section, as it affected my hud's built-in target system display too.

[phkb]

Minor bug report, for a very rare edge case: In G5, if you're in either Divees or Tezabi, and your target system is the other system (Divees or Tezabi), the Hyperdrive status will always say "No target system set".

I think both these systems have the same co-ordinates which is probably causing the confusion. Actually, it is rather confusing to have two systems with the same co-ordinates. Is there some hand-wavium that explains this?

[Wildeblood]

I think both these systems have the same co-ordinates which is probably causing the confusion. Actually, it is rather confusing to have two systems with the same co-ordinates. Is there some hand-wavium that explains this?

It's no mystery - the two planets orbit the same star. There are a few other such pairs.

[phkb]

<slaps forehead> Of course. I should've realised that! I'll have to head back to Lave for some remedial astro-navigation training.

[Venator Dha]

I think both these systems have the same co-ordinates which is probably causing the confusion. Actually, it is rather confusing to have two systems with the same co-ordinates. Is there some hand-wavium that explains this?

It's no mystery - the two planets orbit the same star. There are a few other such pairs.

I would suggest that they are binary stars, not planets (they are different suns).

This really is a issue for the trunk to fix, as now in 1.81 it is possible to move one of the stars a fraction so that they can both be selected in the navigation windows. As it stands they cause a problem for contract deliveries.

[phkb]

Another minor bug report: If you have a compass destination set (like Planet), then go to the F5, F6, F7 or F8 pages, and then go back to your main screen, the "Space Compass Target" shows "Initializing..." but never goes back to the original setting.

[spara]

Another minor bug report: If you have a compass destination set (like Planet), then go to the F5, F6, F7 or F8 pages, and then go back to your main screen, the "Space Compass Target" shows "Initializing..." but never goes back to the original setting.

I'm having trouble reproducing this. I launch, switch the MFD on and it works ok. I switch to F5 and back to F1 and it still works. Did I understand you correctly?

I'll check the other report later. Thanks for reporting .

[Diziet Sma]

Another minor bug report: If you have a compass destination set (like Planet), then go to the F5, F6, F7 or F8 pages, and then go back to your main screen, the "Space Compass Target" shows "Initializing..." but never goes back to the original setting.

I've seen that happen too, but don't recall the exact circumstances.

[Cody]

It seems to work fine here - just had a quick test.

[phkb]

That's weird. I'm running Win64 Oolite, and I think that might be the difference. On looking at the code I found this:

Code: Select all

this.compassTargetChanged = function(whom, mode) {
	this.$targetName = "Initializing...";
	if (!whom) return;//null case

"whom" is showing up as null on my machine when returning from any of the display screens (F5-F8) (I put a debug message in here), so "this.$targetName" never gets set back to the original setting.

It appears that the compassTargetChangedevent is firing for each of the F5-F8 screens, even if the compass target hasn't changed. I suspect this is only happening on Windows.

In any event, I changed the code to this and everything works fine:

Code: Select all

this.compassTargetChanged = function(whom, mode) {
	var hold = this.$targetName;
	this.$targetName = "Initializing...";
	if (!whom) {
		this.$targetName = hold;
		return;//null case
	}

I'd be interested in knowing whether the event is firing as often on Linux or Mac.

[Wildeblood]

PHKB, are you using numeric HUD, perchance?

[phkb]

Actually, no. I'm using the coluber hud with personal mods. You suspect the hud is the culprit?

[phkb]

Wait, just had a thought. One of my mods was to switch the hud from the full version to a cut down version when going to one of the F5-8 screen.s. I'm turning off the space compass, then turning it back on when an exterior view is selected. Thus the null reference in whom. Sorry, my fault. No bug. I screwed up.

[Wildeblood]

Actually, no. I'm using the coluber hud with personal mods. You suspect the hud is the culprit?

Only if your mods include a simplified HUD with no compass in GUI views. (I haven't tried Numeric HUD, but know it's popular and assume it changes to a simpler HUD because of the mess it puts centre of screen.)

Did you happen to log the mode as well as the target in your experiments? Having a null target implies (1) player is docked (2) interstellar space system, or (3) compass not shown on HUD.

Addendum: I knew it!

Wait, just had a thought. One of my mods was to switch the hud from the full version to a cut down version when going to one of the F5-8 screen.s. I'm turning off the space compass, then turning it back on when an exterior view is selected.

Pro-tip: Place the compass off screen by setting both x and x_origin positive. To avoid the problem you had, the compass has to be drawn on the HUD, but it doesn't have to be drawn on the screen.

[spara]

A new version (1.3.2).

* Twin systems work correctly in 1.81. In 1.80 player.ship.targetSystem seems to give a wrong system in twin systems.
* Snitched a better padding method from oolite-contracts-helpers.js.
* Little optimization.