Somehow got like 250 kills at once???

[Thargoid]

@Cim - Just as a thought, might it be worth updating the ship script to make it a bit more robust to this sort of thing? For example on the shipDied (or whatever) event that is giving the kills, first have it check the roleset of the ship and also the mission keys as well. If those are not what they should be for a genuine kill when doing the mission then don't award the bounty for it.

[Zireael]

Good idea, Thargoid!

[cim]

I assume I won't get an extra 256 kills if I run into another Raptor/Constrictor?

Quite likely, I think.

This is interesting... it's listed as a pirate hunter... and I got 0 credits for killing it. So why did it attack me? I was clean.

The constrictor's default AI - again, probably not overridden - assumes that the player is trying to hunt it down.

@Cim - Just as a thought, might it be worth updating the ship script to make it a bit more robust to this sort of thing?

I may as well while I have it open, though there are limits to how much can be done to work around OXP bugs.

[mossfoot]

This is interesting... it's listed as a pirate hunter... and I got 0 credits for killing it. So why did it attack me? I was clean.

The constrictor's default AI - again, probably not overridden - assumes that the player is trying to hunt it down.

Ooooooh, I thought pirate-hunter was a specific kind of bounty-hunter But it means a pirate who hunts people...

[cim]

Wait ... this is odd. The Constrictor ship script which causes the mission to be marked complete is not actually on the Constrictor - it's only added in the mission's worldscript (and this since Eric added this safety measure in 2010). So this isn't a like_ship, it's a partial (and not very safe) copy of an somewhat old version of the Constrictor shipdata (before 2008 it didn't have a ship script either)

I've added an adjustment anyway, so you have to have at least received the mission before a Constrictor met elsewhere will count for it, but this really is well beyond what defensive programming should be expected to cover...

Ooooooh, I thought pirate-hunter was a specific kind of bounty-hunter

Roles are space-separated, so "pirate hunter" means "pirate or hunter"

[mossfoot]

I borked the Ooolitenet!

[Eric Walch]

it's only added in the mission's worldscript

Yep, also in those days we noticed sudden increases in kill scores because some oxp-ers added copies of the constrictor at random in the game for fun. But I remember vaguely that there was also a ship oxp that included the constrictor with a copy of the old legacy script in shipdata. However, I don't see any ancient oxp's in the list of used oxp's.

[Zireael]

it's only added in the mission's worldscript

Yep, also in those days we noticed sudden increases in kill scores because some oxp-ers added copies of the constrictor at random in the game for fun. But I remember vaguely that there was also a ship oxp that included the constrictor with a copy of the old legacy script in shipdata. However, I don't see any ancient oxp's in the list of used oxp's.

Quite possibly Neolite was basd on that ancient oxp?

I borked the Ooolitenet!

[Eric Walch]

Quite possibly Neolite was basd on that ancient oxp?

Not on the old one. It is worse. In my copy of Neolite.oxp, I find the line:

Code: Select all

script = "oolite-constrictor.js";

So Neolite is definitely a culprit. I just downloaded the oxp from the wiki and the oxp still contains the bug despite the warning to Simon in those days.

[cim]

Code: Select all

script = "oolite-constrictor.js";

So Neolite is definitely a culprit. I just downloaded the oxp from the wiki and the oxp still contains the bug despite the warning to Simon in those days.

Though on its own, not so much of a problem, since Neolite also defines "roles" = "constrictor oolite-constrictor"; which means it'll only appear in the right place anyway.

The risk is if you're using Neolite replacement and then another OXP that like_ship's the Constrictor, or modifying some but not all of the properties in the addition set.

The Neolite shipset needs redoing for 1.80 anyway to use the new templating system - any volunteers to do that? (which will fix this and the escape pod bug automatically)