lighting issue in 1.77.1

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

Post Reply
User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

lighting issue in 1.77.1

Post by Commander McLane »

I'm just noticing a very odd lighting bug in Oolite 1.77.1. It must have been there all the time, but I haven't been paying attention. I also guess that not many other people have noticed it, because it only surfaces under unique circumstances, and may not be reproducible on all OSs.

I'm using Mac OS X 10.6.8, and usually start my game not by double-clicking the Oolite icon, but by double-clicking my save game. That has always worked on Mac OS (it may not work under Windows or Linux, I'm not sure). The result is that I get immediately to the F5-screen of my saved game without the spinning Cobra and the usual choice screens.

Now it happens that when I've started the game this way and launch, the main planet does not get lighted by the sun. It's night all around. This happens for all main planets, and regardless of installed planet texturing OXPs. Here's a screen shot showing the sun and a very dark planet that's clearly not illuminated by it:
Image
The planet is in the upper left corner, in case you don't even see it against the dark backdrop.

When I go to the F7-screen, the planet appears correctly illuminated on that screen, and afterwards also in game. All subsequent planets are correctly illuminated from the get-go. So it's as if visiting the F7-screen once switches on the lighting.

This does not happen when I start Oolite by double-clicking the Oolite icon, and then load my game from the loading screen. In this case the lighting is correct from the beginning.

So it looks like starting by double-clicking the save-game circumvents a part of the code that is correctly executed when doing it the "correct" way.

I am not certain when I first encountered the unlighted planets. I guess in 1.77.1, but it could have been earlier.
User avatar
JazHaz
---- E L I T E ----
---- E L I T E ----
Posts: 2991
Joined: Tue Sep 22, 2009 11:07 am
Location: Enfield, Middlesex
Contact:

Re: lighting issue in 1.77.1

Post by JazHaz »

I suspect this is happening to me also, on Windows. Will have to test further.
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6634
Joined: Wed Feb 28, 2007 7:54 am

Re: lighting issue in 1.77.1

Post by another_commander »

Confirmed on trunk on Windows too.
User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4072
Joined: Fri Nov 11, 2011 6:19 pm

Re: lighting issue in 1.77.1

Post by cim »

And on Linux. It's to do with how the lighting effects for non-shadered objects are set up at game start. I'll get a fix together soon.

Edit: should be fixed in 1bab88
Post Reply