Errors and warnings when building 1.79 Master

[Gimi]

Got the following warnings when building master using AC's building the easy way compiler package.

Code: Select all

 Compiling file src/Core/GuiDisplayGen.m ...
src/Core/GuiDisplayGen.m: In function '-[GuiDisplayGen drawGalaxyChart::::]':
src/Core/GuiDisplayGen.m:1995:3: warning: 'b' may be used uninitialized in this
function [-Wmaybe-uninitialized]
src/Core/GuiDisplayGen.m:1995:3: warning: 'g' may be used uninitialized in this
function [-Wmaybe-uninitialized]
src/Core/GuiDisplayGen.m:1995:3: warning: 'r' may be used uninitialized in this
function [-Wmaybe-uninitialized]
 Compiling file src/Core/HeadUpDisplay.m ...

Latest commit to the branch was: Parcel contracts tweak, 27bc2fe by cim.
How do you magicians want us to report Oolite version/build when we have compiled and encountered errors or warning?
Time-stamp, commit hex number?????

[cim]

Commit hex is probably most reliable, since that tells us for free when you last updated and which branch you're on.

Thanks for the report - should be fixed in 2e6beea, I think.

[Thargoid]

I just built a release snapshot exe fine using the same method, although the build did get somewhat confused at the end when it tried to build debug.oxp due to the recent incorporation:

Code: Select all

<snipped out the compiling and copying bits>
strip oolite.app/oolite.exe
cp -rf -u deps/Windows-x86-deps/DLLs/*.dll oolite.app
rm -f oolite.app/js32ECMAv5dbg.dll
make[1]: Leaving directory `/c/oolite/trunk'
cd DebugOXP && make && cd .. && mkdir -p AddOns && rm -rf AddOns/Basic-debug.oxp
 && mv -f DebugOXP/Basic-debug.oxp AddOns/
make[1]: Entering directory `/c/oolite/trunk/DebugOXP'
make[1]: *** No targets specified and no makefile found.  Stop.
make[1]: Leaving directory `/c/oolite/trunk/DebugOXP'
make: *** [release-snapshot] Error 2

I guess maybe the debug make file need a bit of tweaking or even removal?[/color]

[cim]

I just built a release snapshot exe fine using the same method, although the build did get somewhat confused at the end when it tried to build debug.oxp due to the recent incorporation:

Should be fixed in d2498d5

[Thargoid]

Yup, the build I did last night was all OK (did a clean build just in case).

[Gimi]

Following warnings when compiling commit: a9e919c alert_condition setting for HUD legends/dials.
Compiled using AC's latest build environment, 64bit.

Code: Select all

 Compiling file src/Core/GuiDisplayGen.m ...
src/Core/GuiDisplayGen.m: In function '-[GuiDisplayGen drawGalaxyChart::::]':
src/Core/GuiDisplayGen.m:1997:3: warning: 'b' may be used uninitialized in this
function [-Wmaybe-uninitialized]
src/Core/GuiDisplayGen.m:1997:3: warning: 'g' may be used uninitialized in this
function [-Wmaybe-uninitialized]
src/Core/GuiDisplayGen.m:1997:3: warning: 'r' may be used uninitialized in this
function [-Wmaybe-uninitialized]
 Compiling file src/Core/HeadUpDisplay.m ...

[cim]

I was sure I'd already fixed that one. Fixed properly this time - hopefully - in b60c557

[Gimi]

Got this when building Master commit: b9606b5

Code: Select all

 Compiling file src/Core/OOALSoundDecoder.m ...
In file included from src/Core/OOALSoundDecoder.m:31:0:
D:/oolitedev/Msys_x2/1.0/mingw/../devlibs/include/vorbis/vorbisfile.h:82:21: war
ning: 'OV_CALLBACKS_NOCLOSE' defined but not used [-Wunused-variable]
D:/oolitedev/Msys_x2/1.0/mingw/../devlibs/include/vorbis/vorbisfile.h:89:21: war
ning: 'OV_CALLBACKS_STREAMONLY' defined but not used [-Wunused-variable]
D:/oolitedev/Msys_x2/1.0/mingw/../devlibs/include/vorbis/vorbisfile.h:96:21: war
ning: 'OV_CALLBACKS_STREAMONLY_NOCLOSE' defined but not used [-Wunused-variable]

Is there any GIT command I can issue to get last commit on my selected branch?

[cim]

Is there any GIT command I can issue to get last commit on my selected branch?

git log -n1 will get you the most recent one only.

Those warnings are in a 3rd-party library and harmless.

[Gimi]

Got the following when compiling: commit 3fcd4f996ec4a6d94445e5cbb7f0cefee4f311f4

Code: Select all

 Compiling file src/Core/Materials/OOCombinedEmissionMapGenerator.m ...
src/Core/Materials/OOCombinedEmissionMapGenerator.m: In function '-[OOCombinedEmissionMapGenerator initWithEmissionMapSpec:emissionColor:diffuseMap:diffuseColor
:illuminationMapSpec:illuminationColor:isCombinedMap:optionsSpecifier:]':
src/Core/Materials/OOCombinedEmissionMapGenerator.m:153:3: warning: 'OOCombinedEmissionMapGenerator' may not respond to '-constructCacheKey' [enabled by default]
src/Core/Materials/OOCombinedEmissionMapGenerator.m:153:3: warning: (Messages without a matching method signature [enabled by default]
src/Core/Materials/OOCombinedEmissionMapGenerator.m:153:3: warning: will be assumed to return 'id' and accept [enabled by default]
src/Core/Materials/OOCombinedEmissionMapGenerator.m:153:3: warning: '...' as arguments.) [enabled by default]
 Compiling file src/Core/Materials/OOPixMapTextureLoader.m ...
 Compiling file src/Core/OOCrosshairs.m ...

[JensAyton]

Fixed.

[Gimi]

Fixed.

Impressive as always. Thanks.

[Gimi]

Some more warnings when compiling master commit: 7f5e17be823765bd1760b9ab2cde96f904a506e6

Code: Select all

 Compiling file src/Core/OOALSoundDecoder.m ...
In file included from src/Core/OOALSoundDecoder.m:31:0:
D:/oolitedev/Msys_x2/1.0/mingw/../devlibs/include/vorbis/vorbisfile.h:82:21: warning: 'OV_CALLBACKS_NOCLOSE' defined but not used [-Wunused-variable]
D:/oolitedev/Msys_x2/1.0/mingw/../devlibs/include/vorbis/vorbisfile.h:89:21: warning: 'OV_CALLBACKS_STREAMONLY' defined but not used [-Wunused-variable]
D:/oolitedev/Msys_x2/1.0/mingw/../devlibs/include/vorbis/vorbisfile.h:96:21: warning: 'OV_CALLBACKS_STREAMONLY_NOCLOSE' defined but not used [-Wunused-variable]
 Compiling file src/Core/OOALBufferedSound.m ...

[another_commander]

Some more warnings when compiling master commit: 7f5e17be823765bd1760b9ab2cde96f904a506e6

Code: Select all

 Compiling file src/Core/OOALSoundDecoder.m ...
In file included from src/Core/OOALSoundDecoder.m:31:0:
D:/oolitedev/Msys_x2/1.0/mingw/../devlibs/include/vorbis/vorbisfile.h:82:21: warning: 'OV_CALLBACKS_NOCLOSE' defined but not used [-Wunused-variable]
D:/oolitedev/Msys_x2/1.0/mingw/../devlibs/include/vorbis/vorbisfile.h:89:21: warning: 'OV_CALLBACKS_STREAMONLY' defined but not used [-Wunused-variable]
D:/oolitedev/Msys_x2/1.0/mingw/../devlibs/include/vorbis/vorbisfile.h:96:21: warning: 'OV_CALLBACKS_STREAMONLY_NOCLOSE' defined but not used [-Wunused-variable]
 Compiling file src/Core/OOALBufferedSound.m ...

This is the same set of warnings as in your post of 17th November, right?

The warnings are coming from the libvorbis library. We would need to edit the libvorbis headers to remove them. Since they are totally harmless, I don't think we need to worry too much about it and generally we don't mess with third party libraries unless absolutely required.

[Gimi]

This is the same set of warnings as in your post of 17th November, right?

The warnings are coming from the libvorbis library. We would need to edit the libvorbis headers to remove them. Since they are totally harmless, I don't think we need to worry too much about it and generally we don't mess with third party libraries unless absolutely required.

Sorry AC. I jumped too quickly.
I'll try to backtrack and check what has been reported next time. These reports are quite incomprehensible to me, so I live by the rule, if in doubt, report it. I will accept a slap on the wrist for meddling too much though.