[SOLVED] Deep Space Horizons Systems OXP causing CTD

[JazHaz]

The current nightly, 5563 is crashing to desktop upon reaching zero in the hyperspace countdown. I have no errors in the log.

I'm using a lot of OXPs, including BGS-A 1.6 r66 for trunk. Last entry in the log is as follows, so I suspect its the new hyperspace sequence thats breaking.

Code: Select all

19:08:13.041 [BGS-M]: BGS-M: New set:WITCH containing:2 entries.[object Object],[object Object]

I'm using Windows 7 64bit btw.

My full log is here.

[Cody]

The nightly build (r5563), with BGS-A1.6_r66.oxp installed, runs fine here (including the hyperspace jump effects).
Have you got Cabal_Common_Library1.7_r110.oxp installed too? If not, that might be the cause.

[JazHaz]

The nightly build (r5563), with BGS-A1.6_r66.oxp installed, runs fine here (including the hyperspace jump effects).
Have you got Cabal_Common_Library1.7_r110.oxp installed too? If not, that might be the cause.

I've got CCL v1.7 r122 installed. Is that later than r110?

This was with a new Jameson, so I might try it with my Serpent save.

[JazHaz]

Just had another crash, this time using my Serpent save. This time however it was a CTD upon launching from the station.

I got these errors:

Code: Select all

19:32:20.402 [script.javaScript.exception.ooliteDefined]: ***** JavaScript exception (commodityMarkets 0.1): Error: Station.setMarketPrice: Invalid arguments ("luxuries", 1064.112667743795) -- expected Price must be between 0 and 1020 decicredits.
19:32:42.559 [script.javaScript.exception.notDefined]: ***** JavaScript exception (zygo_traffic 0.1): ReferenceError: ZUplanGov is not defined
19:32:57.466 [ship.sanityCheck.failed]: Ship <ShipEntity 0x80920418>{"Interdictor Mine" position: (-7183.55, 13251.1, 27121.9) scanClass: CLASS_NEUTRAL status: STATUS_IN_FLIGHT} EQ_ARMOURY_INTERDICTOR_MINE with scanClass CLASS_NOT_SET; forced to CLASS_NEUTRAL.

[Cody]

I've got CCL v1.7 r122 installed. Is that later than r110?

Just updated to Cabal_Common_Library1.7_r122 and still no problems, even with a virgin Jameson.

[cim]

Is this still happening in the current nightly?

[Thargoid]

This isn't something I can reproduce either, under Win7 Home Prem 64 bit using either release-snapshot or deployment release configuration builds. That's with up to date trunk and CCL 1.7-r122 and BGS-A1.6_r66.

[JazHaz]

Further to this, I have determined that the Deep Space Horizons - Systems OXP is causing the crash to desktop. Here is my log, although there are no errors in it.

I removed all my OXPs and added them in one by one. The CTD has been occurring since at least trunk 5563, upto and including last night's 5587.

[another_commander]

Confirmed and should be fixed on r5588. Please test with tomorrow's nightly and let us know if it is now OK.

[JazHaz]

Confirmed and should be fixed on r5588. Please test with tomorrow's nightly and let us know if it is now OK.

Thanks for the quick solution!

[Cmd. Cheyd]

a_c-
Can you tell me what caused the CTD? I'd like to make sure there's not something I can do to prevent future issues. I know OXPs shouldn't never be able to cause a CTD, but want to make sure I didn't do something questionable.

Jaz-
Since this is resolved, would you mind updating the title accordingly?

[another_commander]

a_c-
Can you tell me what caused the CTD? I'd like to make sure there's not something I can do to prevent future issues. I know OXPs shouldn't never be able to cause a CTD, but want to make sure I didn't do something questionable.

I did not check the OXP itself to see what exactly it was doing, but what was happening is that a planet was attempted to be set up with a nil atmosphere. The fix is simply to check whether the atmosphere is valid before attempting to access it, then start toying with it. Nothing wrong from the OXP side in my opinion. This is something that has to be a fail-safe check from the code side. If I am not mistaken, the bug was introduced with r5503.

[JazHaz]

Confirmed and should be fixed on r5588. Please test with tomorrow's nightly and let us know if it is now OK.

Yes, this is now working.

Changes from previous successful build r5587 to r5588


------------------------------------------------------------------------
r5588 | another_cmdr | 2012-12-23 17:15:19 +0200 | 1 line

Fix for crash when a planet with a nil atmosphere was attempted to be set up.
------------------------------------------------------------------------

This would explain why I got a crash on hyperspacing from Lave with a Jameson (possibly DH Systems doesn't add moons to the Lave system?) and also when launching with my main commander in G3.