Errors and warnings when building 1.77 trunk

[Gimi]

Still getting build errors with r5162

Code: Select all

 Compiling file src/Core/OOOpenGL.m ...
 Compiling file src/Core/OOOpenGLExtensionManager.m ...
In file included from src/Core/OOOpenGLExtensionManager.m:32:
src/Core/NSThreadOOExtensions.h:44: error: expected ';' before '__attribute__'
src/Core/NSThreadOOExtensions.h:51: error: expected ';' before '__attribute__'
src/Core/NSThreadOOExtensions.h:58: error: expected ';' before '__attribute__'
make[3]: *** [obj.win.spk/oolite.obj/OOOpenGLExtensionManager.m.o] Error 1
make[2]: *** [internal-objc_program-all_] Error 2
make[1]: *** [oolite.all.objc-program.variables] Error 2
make: *** [internal-all] Error 2

[JensAyton]

Open src\Core\NSThreadOOExtensions.h and remove the DEPRECATED_MSG bits (up to but not including the semicolon).

[Gimi]

Open src\Core\NSThreadOOExtensions.h and remove the DEPRECATED_MSG bits (up to but not including the semicolon).

Thank you, no errors or warnings now.

[Gimi]

More warning and errors with r5163

Code: Select all

$ make debug=no
Making all for objc_program oolite...
 Compiling file src/Core/OOOpenGLExtensionManager.m ...
In file included from src/Core/OOOpenGLExtensionManager.m:32:
src/Core/NSThreadOOExtensions.h:42: error: expected identifier or '(' before '<<' token
src/Core/NSThreadOOExtensions.h:48: warning: '@end' must appear in an @implementation context
src/Core/NSThreadOOExtensions.h:63: error: expected identifier or '(' before '==' token
In file included from src/Core/OOOpenGLExtensionManager.m:34:
src/Core/ResourceManager.h:85: error: expected ')' before 'OOSound'
src/Core/ResourceManager.h:86: error: expected ')' before 'OOMusic'
src/Core/OOOpenGLExtensionManager.m: In function '-[OOOpenGLExtensionManager init]':
src/Core/OOOpenGLExtensionManager.m:169: warning: 'NSLock' may not respond to '-ooSetName:'
src/Core/OOOpenGLExtensionManager.m:169: warning: (Messages without a matching method signature
src/Core/OOOpenGLExtensionManager.m:169: warning: will be assumed to return 'id' and accept
src/Core/OOOpenGLExtensionManager.m:169: warning: '...' as arguments.)
make[3]: *** [obj.win.spk/oolite.obj/OOOpenGLExtensionManager.m.o] Error 1
make[2]: *** [internal-objc_program-all_] Error 2
make[1]: *** [oolite.all.objc-program.variables] Error 2
make: *** [internal-all] Error 2

[Tricky]

Interesting, I don't get the error just the second warning.

Code: Select all

$ make -f Makefile release-snapshot
make -f GNUmakefile SNAPSHOT_BUILD=yes VERSION_STRING=1.77.0.5163 debug=no
make[1]: Entering directory `/c/cygwin/usr/local/src/oolite/trunk'
Making all for objc_program oolite...
 Compiling file src/Core/OOOpenGLExtensionManager.m ...
src/Core/OOOpenGLExtensionManager.m: In function '-[OOOpenGLExtensionManager init]':
src/Core/OOOpenGLExtensionManager.m:169: warning: 'NSLock' may not respond to '-ooSetName:'
src/Core/OOOpenGLExtensionManager.m:169: warning: (Messages without a matching method signature
src/Core/OOOpenGLExtensionManager.m:169: warning: will be assumed to return 'id' and accept
src/Core/OOOpenGLExtensionManager.m:169: warning: '...' as arguments.)
 Compiling file src/Core/NSThreadOOExtensions.m ...
 Compiling file src/Core/OOAsyncQueue.m ...
 Compiling file src/Core/OOAsyncWorkManager.m ...
 Compiling file src/Core/OOLogging.m ...
 Compiling file src/Core/OOLogOutputHandler.m ...
 Linking objc_program oolite ...
/OOgstep/System/Library/Makefiles/mkinstalldirs oolite.app
/OOgstep/System/Library/Makefiles/mkinstalldirs oolite.app/Resources
cp -rf -u Resources oolite.app
cp -rf -u Schemata oolite.app/Resources
cp -rf -u deps/Cross-platform-deps/espeak-data oolite.app/Resources
cp -rf -u src/Cocoa/Info-Oolite.plist oolite.app/Resources/Info-gnustep.plist
cp -rf -u obj.win.spk/oolite.exe oolite.app/oolite.exe
strip oolite.app/oolite.exe
cp -rf -u deps/Windows-x86-deps/DLLs/*.dll oolite.app
rm -f oolite.app/js32ECMAv5dbg.dll
make[1]: Leaving directory `/c/cygwin/usr/local/src/oolite/trunk'
cd DebugOXP && make && cd .. && mkdir -p AddOns && rm -rf AddOns/Basic-debug.oxp && mv -f DebugOXP/Basic-debug.oxp AddOns/
/c/cygwin/usr/local/src/oolite/trunk/DebugOXP
make[1]: Entering directory `/c/cygwin/usr/local/src/oolite/trunk/DebugOXP'
rm -rf Basic-debug.oxp
mkdir Basic-debug.oxp
mkdir Basic-debug.oxp/Config
mkdir Basic-debug.oxp/Scripts
cp Resources/debugConfig.plist Basic-debug.oxp/Config/
cp Resources/DebugOXPLocatorBeacon.magic Basic-debug.oxp/
cp Resources/oolite-debug-console.js Basic-debug.oxp/Scripts/
cp requires.plist Basic-debug.oxp/
make[1]: Leaving directory `/c/cygwin/usr/local/src/oolite/trunk/DebugOXP'

Not tested it yet, just compiled it just now.

EDIT: Nearly forgot, compiling under Windows.

[JensAyton]

Gimi, your problem is caused by the merge failure you got when you updated. Throw out your modified NSThreadOOExtensions.h and update again.

[Gimi]

I'm using the "Building Oolite Windows from source - The Easier Way" setup. As such I suspect that there are differences in our set-ups. You seem to have a more complete setup from what I can see from your post.

[Gimi]

Still getting this with r5164.

Should I do a fresh co.

Code: Select all

Making all for objc_program oolite...
 Compiling file src/Core/OOOpenGLExtensionManager.m ...
In file included from src/Core/OOOpenGLExtensionManager.m:32:
src/Core/NSThreadOOExtensions.h:42: error: expected identifier or '(' before '<<' token
src/Core/NSThreadOOExtensions.h:48: warning: '@end' must appear in an @implementation context
src/Core/NSThreadOOExtensions.h:63: error: expected identifier or '(' before '==' token
In file included from src/Core/OOOpenGLExtensionManager.m:34:
src/Core/ResourceManager.h:85: error: expected ')' before 'OOSound'
src/Core/ResourceManager.h:86: error: expected ')' before 'OOMusic'
make[3]: *** [obj.win.spk/oolite.obj/OOOpenGLExtensionManager.m.o] Error 1
make[2]: *** [internal-objc_program-all_] Error 2
make[1]: *** [oolite.all.objc-program.variables] Error 2
make: *** [internal-all] Error 2

[Gimi]

Gimi, your problem is caused by the merge failure you got when you updated. Throw out your modified NSThreadOOExtensions.h and update again.

Oh, sorry, didn't see this at first. Will fix now.

Edit: And that solved it. Thanks, I just learned something.

[Gimi]

Compile error r5168

Code: Select all

$ make debug=no
Making all for objc_program oolite...
 Compiling file src/Core/Debug/OODebugMonitor.m ...
 Compiling file src/Core/Debug/OODebugSupport.m ...
 Compiling file src/Core/Debug/OOJSConsole.m ...
 Compiling file src/Core/Entities/DockEntity.m ...
 Compiling file src/Core/Entities/DustEntity.m ...
 Compiling file src/Core/Entities/Entity.m ...
 Compiling file src/Core/Entities/OOParticleSystem.m ...
 Compiling file src/Core/Entities/PlayerEntity.m ...
src/Core/Entities/PlayerEntity.m: In function '-[PlayerEntity setGuiToGameOptionsScreen]':
src/Core/Entities/PlayerEntity.m:6136: error: 'displayModeIndex' undeclared (first use in this function)
src/Core/Entities/PlayerEntity.m:6136: error: (Each undeclared identifier is reported only once
src/Core/Entities/PlayerEntity.m:6136: error: for each function it appears in.)
make[3]: *** [obj.win.spk/oolite.obj/PlayerEntity.m.o] Error 1
make[2]: *** [internal-objc_program-all_] Error 2
make[1]: *** [oolite.all.objc-program.variables] Error 2
make: *** [internal-all] Error 2

[Gimi]

And r5169 fixed last reported compile error. Thanks.

[Eric Walch]

Compile error r5168

Code: Select all

$ make debug=no

Same here:

Code: Select all

/Users/ericwalch/Oolite/trunk/src/Core/Entities/PlayerEntity.m:6136:35: error: use of undeclared identifier 'displayModeIndex'
                         mode = [modeList objectAtIndex:displayModeIndex];

Although the error is only there in a 'test build' not in a 'debug build'.

[Eric Walch]

And r5169 fixed last reported compile error. Thanks.

Not with me. That build complains about a wrong integer comparison. But Ahruman fixed that with r5170.

And I noticed that in test configuration the code compiles without error in the linking process. Not as fast as a debug compile, but at least it does compile.

But, compiling okay is one thing. On launching Oolite I get a nice message on the startup screen:

Code: Select all

Oolite failed to start up, because an unhandled exception occurred.
An exception of type NSInvalidArgumentException occurred. If this problem persists, please file a bug report.

In the log:

Code: Select all

[dataCache.rebuild.explicitFlush]: Cache explicitly flushed with always-flush-cache preference. Rebuilding from scratch.
[system]: Unknown class 'Groolite', using 'NSObject' instead. Encountered in Interface Builder file at path /Users/ericwalch/Oolite/trunk/build/TestRelease/Oolite.app/Contents/Resources/Oolite.nib.
[system]: Could not connect the action goFullscreen: to target of class GameController
[startup.exception]: ***** Unhandled exception during startup: NSInvalidArgumentException (-[GameController setUpDisplayModes]: unrecognized selector sent to instance 0x100a3bb10).

Closing log at 2012-08-05 23:32:14 +0200.

[Gimi]

Compile error r5168

Code: Select all

$ make debug=no

Same here:

Code: Select all

/Users/ericwalch/Oolite/trunk/src/Core/Entities/PlayerEntity.m:6136:35: error: use of undeclared identifier 'displayModeIndex'
                         mode = [modeList objectAtIndex:displayModeIndex];

Although the error is only there in a 'test build' not in a 'debug build'.

I have two environments now, one with debug and one without. Never got as far as updating my debug build with r5168. Why would that matter though? (Explained in layman terms please.)

Also (again in layman terms), when you say a test compile, do you mean with "debug=no". I got no warnings or errors with r5169, either with "debug=no" or "debug=yes".

[cim]

I have two environments now, one with debug and one without. Never got as far as updating my debug build with r5168. Why would that matter though? (Explained in layman terms please.)

Also (again in layman terms), when you say a test compile, do you mean with "debug=no". I got no warnings or errors with r5169, either with "debug=no" or "debug=yes".

debug => "debug=yes"
test => "debug=no"
release => "DEPLOYMENT_RELEASE_CONFIGURATION=yes debug=no"

The different build types have some differences in which code is enabled (e.g. test and debug have debug info on the FPS counter, but release doesn't), and what compiler settings are used to build it (e.g. test and release compiles are optimised for execution speed, while debug compiles are optimised for faster compilation and easier debugging). As a result some bugs only affect some but not all build types.