Bug with decimal-separator

General discussion for players of Oolite.

Moderators: winston, another_commander

Post Reply
Poovga
Competent
Competent
Posts: 45
Joined: Tue Jul 31, 2007 6:28 pm

Bug with decimal-separator

Post by Poovga »

Hello Commanders,
I haven't been playing Oolite much these two last years but I am back in trade and fight :)

I just loaded the new version and a bunch of OXP's, including my only OXP Oolite en Français (Oolite in French)

On the F2 screen (Commander's presentation), the total of money is shown as 12number-decimal-separator2 Cr and the bounties while flying are unreadable.
I have been unable to find "decimal-separator" in the config files.

I'd like to know if it comes from my OXP, so I could modify it... I may have replaced the decimal separator by a coma (as we are used to do in French) instead of the English dot. I imagine that the coma could mean another thing for the programming language.

Has anybody got a clue?

Thanks,
Travelling is a dream, dreaming is a travel
User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 16081
Joined: Sat Jul 04, 2009 9:31 pm
Location: The Lizard's Claw
Contact:

Re: Bug with decimal-separator

Post by Cody »

The "number-decimal-separator" = "."; is line 40 in Oolite's descriptions.plist, and a comma will work... I think.
I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
Poovga
Competent
Competent
Posts: 45
Joined: Tue Jul 31, 2007 6:28 pm

Re: Bug with decimal-separator

Post by Poovga »

Hola El Viejo,

Here are the not working lines :

// Currency format
"@-credits" = "%@ ₢";

// *** Misc. messages ***
// Messages used when awarding bounties
"bounty-@" = "Prime : %@";
"total-@-credits" = "Total : %@";

Can you see anythong wrong with them?

Thanks,
Poovga
Travelling is a dream, dreaming is a travel
User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 16081
Joined: Sat Jul 04, 2009 9:31 pm
Location: The Lizard's Claw
Contact:

Re: Bug with decimal-separator

Post by Cody »

Hola! Heh, that's beyond me... wait for a boffin to appear.
I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
User avatar
Eric Walch
Slightly Grand Rear Admiral
Slightly Grand Rear Admiral
Posts: 5536
Joined: Sat Jun 16, 2007 3:48 pm
Location: Netherlands

Re: Bug with decimal-separator

Post by Eric Walch »

El Viejo wrote:
Hola! Heh, that's beyond me... wait for a boffin to appear.
Why, it looks that you already pointed to the right location in the right file. I just downloaded the french localisation version. That does not include those separators. So probably they need to be added there from Oolite itself and adapted to the localized files.

Actually, the whole installation description for those files are a bug. It is not offered as a nice oxp that overrides the internal descriptions, but it tells to replace Oolites internal files with it. But that only works with Oolite 1.72.2 were it was tested with. In newer oolites you will lose essential descriptions, like the new formatting rules.

The way it is presented it is already incompatible with Oolite 1.73 and higher. It would already be compatible with any oolite if the folder was renamed to 'Config' and put in a new folder "French_Localisation.oxp" But a complete rewrite with the overwrite_plists would be better.

If Poovga is able to make it a working oxp for him, it would be good for al french speaking players that it replaces the current buggy version. (Look for instance to the German or Italian version how they created an oxp from it.

EDIT: The german version I just downloaded has a bug that it contains an oxp inside an oxp. No idea what went wrong there. Oolite can work correctly with it, but its not a good example, so stick to the Italian version. :P
Poovga
Competent
Competent
Posts: 45
Joined: Tue Jul 31, 2007 6:28 pm

Re: Bug with decimal-separator

Post by Poovga »

Eric,

My only OXP is no more working *sigh*.
I start by removing the buggy files from box.net and links...
Then I'll have a look to the Italian files and do what have to be done.

More job on my plate, but French commanders will fly back with a better experience...

Thanks for quick tracking of the problem and the solution.
Travelling is a dream, dreaming is a travel
User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Re: Bug with decimal-separator

Post by Commander McLane »

Poovga wrote:
Eric,

My only OXP is no more working *sigh*.
I start by removing the buggy files from box.net and links...
Then I'll have a look to the Italian files and do what have to be done.
The only thing you really need to do is to look into the current descriptions.plist and translate everything in there, especially those lines which didn't exist at the time of Oolite 1.72.
Poovga
Competent
Competent
Posts: 45
Joined: Tue Jul 31, 2007 6:28 pm

Re: Bug with decimal-separator

Post by Poovga »

Ok... Seems easier put that way :)
But description.plist is a big file...
Travelling is a dream, dreaming is a travel
User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Re: Bug with decimal-separator

Post by Commander McLane »

Poovga wrote:
Ok... Seems easier put that way :)
But description.plist is a big file...
Just open the 1.76.1 description.plist and the existing French OXP description.plist side by side. Copy any entry that isn't yet in the French OXP into it and translate it. Delete any entry from the French OXP that has no counterpart in Oolite 1.76.1.

Warning: many entries have been renamed since 1.72. So it may indeed be a lot of work after all this time.
Poovga
Competent
Competent
Posts: 45
Joined: Tue Jul 31, 2007 6:28 pm

Re: Bug with decimal-separator

Post by Poovga »

Hello McLane,

I am on it: Oolite is my favorite line on my resume :)

If it goes well, there is still a few hours of translating to go and, probably, a couple of days for testing...
Update to come then.
Travelling is a dream, dreaming is a travel
Nzingu
Harmless
Harmless
Posts: 1
Joined: Thu Jul 19, 2012 3:21 pm

Re: Bug with decimal-separator

Post by Nzingu »

Hi all !!

I'm so glad i found this topic !

I tried to install french on oolite, with a rather poor result !
In this state, french oolite isn't easy access !

I'm a newbie in this game, but i like the project (though it's sometimes really long to get to the station !)
and i think i could help in completing the translation job (not good at all at coding, but i'd like my kids to play on linux,
and i can exchange english for french in some part of a file)

So please Poovga, tell me if you got something done about that, otherwise i may try and do the job !

Thank you all !


Nzingu

PS: I'd really like to get rid of the decimal-separator too !
Last edited by Nzingu on Sat Jul 21, 2012 1:13 pm, edited 2 times in total.
User avatar
Fatleaf
Intergalactic Spam Assassin
Intergalactic Spam Assassin
Posts: 1988
Joined: Tue Jun 08, 2010 5:11 am
Location: In analysis mode on Phaelon
Contact:

Re: Bug with decimal-separator

Post by Fatleaf »

Nzingu wrote:
I'm a newbie in this game, but i like the project (though it's sometimes really long to get to the station !)
and i think i could help in completing the translation job (not good at all coding, but i can exchange english for french in some part of a file)

So please Poovga, tell me if you got something done about that, otherwise i may try and do the job !

Thank you all !
Welcome To The Friendliest Board This Side Of RiedquatTM Nzingu.

We all were once a newbie so stick with it and you will find everyone here ready to help. It is great you are offering to help and I'm sure it will be greatly appreciated.
Find out about the early influences of Fatleaf here. Also his OXP's!
Holds the Ooniversal record for "Thread Necromancy"
Post Reply