Latest build (r344) problem with names

[aegidian]

steps:-

start new game

save under name 'Anything'

screen goes to status screen with name set correctly

go to chart screen [f6]

go to long range chart [f6]

return to status screen [f5]

Name is now blank!


I suspect that at some point the commander name (held as a pointer to an NSString) is being set to be the same as the text input (also held as a pointer to a NSString) when in fact it is the content of the name NSString that should be set from the content of the text input.

(Just installed new NVidia drivers on the GF's PC and Wow! does it make a difference to how well Oolite runs - from 5fps to 50fps).

[winston]

If it made that much difference it sounds like the old drivers weren't working at all and it was using software rendering (well, that's what happens on Linux if your accelerated drivers aren't working).

The bug prolly isn't specific to the Win32 build, I bet it happens in Linux (but I'm going to bed now so I can't say for sure, and my sinuses feel ready to explode in a giant snotty explosion so...)

[Galileo]

The bug prolly isn't specific to the Win32 build, I bet it happens in Linux

Yep, I'm seeing it in Linux.

[winston]

As predicted this is caused by the commander name being set to the GUI's pointer to the commander string rather than a copy of the string being made. The one-liner fix is in r367.

[JensAyton]

Could this be a fix for the “Commander Jamesonxxlnjbarnej” bug, too?

[winston]

It's quite likely.