Missing equipment after combat

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

User avatar
Eric Walch
Slightly Grand Rear Admiral
Slightly Grand Rear Admiral
Posts: 5536
Joined: Sat Jun 16, 2007 3:48 pm
Location: Netherlands

Re: Missing equipment after combat

Post by Eric Walch »

Eric Walch wrote:
A bug still left is that preinstalled equipment on the buy screen is still validated. But that should already be validated before showing up. Currently there is only a check for incompatible equipment so you won't get a ship pre-fitted with two incompatible items.
Even that was not true because of a bug in that exclusion code. incompatible equipment was only removed from the selection list, but the code still proceeded with the already selected incompatible equipment and added it to the ship.

Anyhow, it bothered me knowing that equipment with missing dependencies could be preinstalled in ships on the shipyard. I now added checks for "requires_equipment", "requires_any_equipment" and fixed the check for "incompatible_with_equipment". And tested all versions, as apparently the existing "incompatible_with_equipment" check was never tested for the shipyard.
(Fixed in r4601)
Post Reply