Armoury 1.07.oxp error spotted in my Latest.log

[Switeck]

I'm running Windows XP SP3, oolite-trunk-1.75.3.4553-dev.win32.exe

I got this error message:
02:47:38.953 [script.javaScript.exception.unexpectedType]: ***** JavaScript exception (drones_Pickup 2.0): TypeError: this.ship.master is null
02:47:38.953 [script.javaScript.exception.unexpectedType]: ../AddOns/Armoury 1.07.oxp/Scripts/drones_Pickup.js, line 36.

I think it's reacting to this line:
if(this.ship.master.isPlayer) player.commsMessage(this.ship.name+": Attacking "+targets[0].displayName)

(I would've reported this in the Armory thread in Expansion Pack forum...but I couldn't find it. )

[maik]

I would've reported this in the Armory thread in Expansion Pack forum...but I couldn't find it.

That's because it is Armoury Here it is.

[Thargoid]

It is indeed, and it's easily fixed. Just change

if(this.ship.master.isPlayer)

to

if(this.ship.master && this.ship.master.isPlayer)

and you're done. I'll tweak it in the next release of Armoury. All it does is check if the person who launched the drone is the player, and if it is then sends them a message update (not too much point in sending one to an NPC). But it does presume that they still exist, which may or may not be the case.

Anyway thanks, will tweak...

[Switeck]

My bad, missed the u in searching for it.

"it does presume that they still exist"
They probably didn't exist anymore because of the tidal wave of Thargoid Warships and pirate ships loose in the system.

Change this also?:

Code: Select all

this.shipTargetDestroyed = function(target)
	{
	if(this.ship.master.isPlayer)

to:

Code: Select all

this.shipTargetDestroyed = function(target)
	{
	if(this.ship.master && this.ship.master.isPlayer)

[Thargoid]

Yes.

I'll fully go through the script when I update it.