chance-key in shipyard and passenger berths

[Commander McLane]

There are reports that setting the chance key to 1 for a ship which can carry passenger berths may result in the ship's cargo hold to be completely filled up with passenger berths.

I think that shouldn't happen.

[Commander McLane]

I just downloaded the Boa Clipper.oxp, because it is one of the examples mentioned in the posts linked from above.

I set the chance key to 1 and fired up Oolite.

It took three systems until I found one where the Boa Clipper was for sale at all.

There were two ships for sale. Both had different extra equipment, and both had by no means all extra equipment. Only one had exactly one passenger berth.

So all I can say is that it doesn't happen here with trunk rev4482.

Was the chance key changed somehow? I was expecting to find all optional equipment installed if set to 1, but clearly that isn't the case.

[Smivs]

I don't know if it's significant but when I'd set the chance to 1 I also had the TL set at 1, so I was getting lots of them in the shipyards. The passenger berths did appear in nearly all of them IIRC.