Oolite v1.75.1.4392 (x86-32 test release) docking error?

[Switeck]

The game didn't crash...but definitely some sort of internal docking error:

[log.header]: Opening log for Oolite development version 1.75.1.4392 (x86-32 test release) under Windows at 2011-02-23 07:37:41 -0600.
2 processors detected.
Build options: spoken messages, mass/fuel pricing, JavaScript console support, OXP verifier, localization tools, debug GraphViz support, JavaScript profiling.

Note that the contents of the log file can be adjusted by editing logcontrol.plist.

[display.mode.list.native]: Windows native resolution detected: 1024 x 768
[joystick.init]: Number of joysticks detected: 0
[dataCache.notFound]: No data cache found, starting from scratch.
[searchPaths.dumpAll]: Unrestricted mode - resource paths:
Resources
../AddOns
../AddOns/auto_eject.oxp
../AddOns/BountyScannerv2.0.oxp
../AddOns/clearskies.oxp
../AddOns/display_reputation.oxp
../AddOns/Flight Log 1.03.oxp
../AddOns/GalDrivePod v1.0.oxp
../AddOns/griff_prototype_boa.oxp
../AddOns/griff_shipset_all_in_1.oxp
../AddOns/LinkG7 v0.1.oxp
../AddOns/LongRangeScanner v0.2.oxp
../AddOns/Missile Analyser 1.2.oxp
../AddOns/Missile Countermeasures 0.4.oxp
../AddOns/OMEGA.oxp
../AddOns/OresratiChalenge v0.1.1.oxp
../AddOns/RepairBots 2.01.oxp
../AddOns/Rock_Hermit_Locator1.3.2.oxp
../AddOns/SaveAnywhere3.1.oxp
../AddOns/sell_equipment.oxp
../AddOns/ShipSpawner v0.1.oxp
../AddOns/Switeck_mod_v0.4.oxp
../AddOns/Target Autolock Plus 1.12.oxp
../AddOns/Traffic Control 1.11.oxp
../AddOns/Welcome Mat 1.11.oxp
../AddOns/WormholeDronesWIP.oxp
[rendering.opengl.version]: OpenGL renderer version: 1.5.3 ("1.5.3"). Vendor: "NVIDIA Corporation". Renderer: "GeForce2 GTS/AGP/SSE2".
[rendering.opengl.extensions]: OpenGL extensions (74):
GL_EXT_abgr, GL_S3_s3tc, GL_IBM_texture_mirrored_repeat, GL_EXT_texture_edge_clamp, GL_EXT_separate_specular_color, GL_EXT_blend_minmax, GL_EXT_texture_object, GL_ARB_texture_env_add, GL_NV_texture_env_combine4, GL_EXT_texture_cube_map, GL_EXT_texture_env_dot3, GL_IBM_rasterpos_clip, GL_ARB_texture_env_dot3, GL_NV_light_max_exponent, GL_EXT_blend_subtract, GL_ARB_multitexture, GL_NV_register_combiners, GL_EXT_stencil_wrap, GL_NV_vertex_program, GL_ARB_texture_env_combine, GL_NV_fog_distance, GL_SUN_slice_accum, GL_EXT_packed_pixels, GL_EXT_texture_env_add, GL_SGIS_texture_lod, GL_ARB_transpose_matrix, GL_NV_texgen_reflection, GL_NV_packed_depth_stencil, GL_ARB_shading_language_100, GL_EXT_rescale_normal, GL_EXT_secondary_color, GL_EXT_paletted_texture, GL_ARB_texture_mirrored_repeat, GL_NV_fence, GL_EXT_draw_range_elements, GL_EXT_texture_lod_bias, GL_EXT_texture_filter_anisotropic, WGL_EXT_swap_control, GL_SGIS_generate_mipmap, GL_NV_texture_rectangle, GL_ARB_texture_rectangle, GL_ARB_point_sprite, GL_EXT_texture_lod, GL_EXT_texture_compression_s3tc, GL_ARB_vertex_shader, GL_ARB_vertex_buffer_object, GL_WIN_swap_hint, GL_ARB_shader_objects, GL_ARB_imaging, GL_EXT_Cg_shader, GL_NV_vertex_array_range, GL_NV_point_sprite, GL_NV_pixel_data_range, GL_SGIS_multitexture, GL_NV_vertex_array_range2, GL_KTX_buffer_region, GL_EXT_fog_coord, GL_ARB_window_pos, GL_EXT_point_parameters, GL_EXT_texture_env_combine, GL_ARB_vertex_program, GL_EXT_shared_texture_palette, GL_EXT_compiled_vertex_array, GL_EXT_bgra, GL_ARB_texture_cube_map, GL_ARB_point_parameters, GL_EXT_vertex_array, GL_EXT_multi_draw_arrays, GL_ARB_texture_compression, GL_EXT_clip_volume_hint, GL_EXT_blend_color, GL_NV_vertex_program1_1, GL_NV_blend_square, GL_EXT_pixel_buffer_object
[rendering.opengl.shader.support]: Shaders will not be used (OpenGL extension GL_ARB_fragment_shader is not available).
[shipData.load.begin]: Loading ship data.
[script.load.world.listAll]: Loaded 26 world scripts:
auto-eject 1.0
Bounty Scanner 2.0 2.00
display-reputation-contract 1.1
display-reputation-passenger 1.1
FlightLog 1.02
GalDrivePod 1.0
linkG7_autoJumper 0.1
LinkG7_main 0.1
LongRangeScanner 0.1
Mauiby's Wormhole Drones 1.1
mcm_system 1.0
missile_analyser 1.2
oolite-cloaking-device 1.75.1
oolite-constrictor-hunt 1.75.1
oolite-nova 1.75.1
oolite-thargoid-plans 1.75.1
oolite-trumbles 1.75.1
oresratichalange_main 0.0
Repair system 2.0
rockHermit_Locator 1.3.3
Save Anywhere OXP 3.1 3.1
sell_equipment 1.3
ship_spawner 0.1
targetAutolock 1.11
TrafficControl 1.1
Welcome Information Script 1.1
[Save Anywhere OXP 3.1]: initialising Save Anywhere OXP 3.1
[Flightlog]: Kills Store set to player score
[loading.complete]: ========== Loading complete. ==========
[script.load.world.listAll]: Loaded 26 world scripts:
auto-eject 1.0
Bounty Scanner 2.0 2.00
display-reputation-contract 1.1
display-reputation-passenger 1.1
FlightLog 1.02
GalDrivePod 1.0
linkG7_autoJumper 0.1
LinkG7_main 0.1
LongRangeScanner 0.1
Mauiby's Wormhole Drones 1.1
mcm_system 1.0
missile_analyser 1.2
oolite-cloaking-device 1.75.1
oolite-constrictor-hunt 1.75.1
oolite-nova 1.75.1
oolite-thargoid-plans 1.75.1
oolite-trumbles 1.75.1
oresratichalange_main 0.0
Repair system 2.0
rockHermit_Locator 1.3.3
Save Anywhere OXP 3.1 3.1
sell_equipment 1.3
ship_spawner 0.1
targetAutolock 1.11
TrafficControl 1.1
Welcome Information Script 1.1
[Save Anywhere OXP 3.1]: initialising Save Anywhere OXP 3.1
[Added a trader.]: 15
[Added a PIRATE!]: 11
[Added a PIRATE!]: 10
[Added a PIRATE!]: 11
[Added a PIRATE!]: 21
[Added a PIRATE!]: 22
[Added a trader.]: 14
[Added a PIRATE!]: 22
[Added a PIRATE!]: 22
[Added a PIRATE!]: 23
[Added a PIRATE!]: 24
[Added a trader.]: 13
[Added a trader.]: 14
[Added a PIRATE!]: 23
[Added a PIRATE!]: 23
[Added a PIRATE!]: 22
[Added a trader.]: 14
[Added a trader.]: 15
[Added a PIRATE!]: 22
[Added a PIRATE!]: 23
[Added a PIRATE!]: 23
[Added a trader.]: 16
[Added a PIRATE!]: 24
[Added a PIRATE!]: 22
[Added a PIRATE!]: 22
[Added a PIRATE!]: 23
[Added a PIRATE!]: 24
[Added a trader.]: 16
[Added a PIRATE!]: 25
[Added a PIRATE!]: 26
[Added a PIRATE!]: 27
[Added a trader.]: 17
[Added a PIRATE!]: 26
[Added a PIRATE!]: 25
[Added a trader.]: 15
[Added a PIRATE!]: 26
[Added a PIRATE!]: 27
[Added a PIRATE!]: 26
[Added a PIRATE!]: 27
[Added a trader.]: 10
[Added a PIRATE!]: 27
[Added a trader.]: 10
[Added a PIRATE!]: 27
[Added a trader.]: 11
[Added a PIRATE!]: 27
[Added a PIRATE!]: 28
[Added a trader.]: 12
[Added a PIRATE!]: 28
[Added a PIRATE!]: 29
[Added a PIRATE!]: 30
[Added a trader.]: 13
[Added a PIRATE!]: 29
[Added a trader.]: 12
[Added a PIRATE!]: 30
[Added a PIRATE!]: 31
[Added a PIRATE!]: 32
[Added a trader.]: 12
[Added a PIRATE!]: 33
[Added a PIRATE!]: 34
[Added a trader.]: 13
[Added a PIRATE!]: 35
[Added a trader.]: 13
[Added a PIRATE!]: 36
[Added a PIRATE!]: 37
[Added a PIRATE!]: 38
[Added a PIRATE!]: 38
[Added a PIRATE!]: 39
[Added a PIRATE!]: 38
[Added a trader.]: 10
[Added a PIRATE!]: 38
[Added a PIRATE!]: 39
[Added a PIRATE!]: 39
[Added a trader.]: 11
[Added a PIRATE!]: 39
[Added a trader.]: 12
[Added a trader.]: 13
[Added a trader.]: 14
[Added a trader.]: 15
[Added a trader.]: 16
[Added a PIRATE!]: 39
[Added a trader.]: 17
[Added a trader.]: 18
[Added a PIRATE!]: 39
[Added a trader.]: 19
[Added a PIRATE!]: 35
[Added a PIRATE!]: 36
[Added a trader.]: 20
[Added a PIRATE!]: 36
[Added a trader.]: 21
[Added a trader.]: 22
[Added a PIRATE!]: 37
[Added a trader.]: 23
[Added a PIRATE!]: 37
[Added a trader.]: 24
[Added a PIRATE!]: 38
[Added a PIRATE!]: 39
[Added a trader.]: 26
[Added a PIRATE!]: 38
[Added a PIRATE!]: 39
[Added a PIRATE!]: 39
[Added a PIRATE!]: 39
[Added a PIRATE!]: 37
[Added a PIRATE!]: 37
[general.error.inconsistentState]: ***** ERROR: status is STATUS_DOCKED, but dockedStation is nil; treating as not docked. This is an internal error, please report it.
[Added a trader.]: 25
[general.error.inconsistentState]: ***** ERROR: status is STATUS_DOCKED, but dockedStation is nil; treating as not docked. This is an internal error, please report it.
[Added a PIRATE!]: 38
[Added a trader.]: 25

I had created 2 Rock Hermits near the Witchspace Beacon using this script:

Code: Select all

this.shipLaunchedFromStation = function ()
{
	if(system.sun && system.countShipsWithRole("rockhermit") <2)
	{
		system.addShipsToRoute("rockhermit", 1, 0, "wp", 9000);
	}
}

I then docked with one, and then docked with the other. I'm guessing that's what triggered those messages, as I don't recall docking with anything else around that time. It could be NPC ships docking with the Rock Hermits and/or main station though. As far as I know, there were no other dockable objects in the system.

I had however edited the Rock Hermits, because previously they were spawning with a yellow icon on radar:

Code: Select all

	"rock-hermit" =
	{
		has_shield_booster = 0.3;
		has_shield_enhancer = 0.1;
		heat_insulation = 7;
		scan_class = "CLASS_ROCK";
	};

...But I don't think that's the cause of the problem.

Are Rock Hermits supposed to spit out offender and fugitive ships in its defense? At the very least, they are NOT reporting as "[shipname] (clean)" -- all I see is "[shipname]".

[Commander McLane]

Code: Select all

[general.error.inconsistentState]: ***** ERROR: status is STATUS_DOCKED, but dockedStation is nil; treating as not docked. This is an internal error, please report it.

I think this type of error is normally generated by a script, if you forgot to check again whether the player is still docked when you display a mission screen.

Or something of the like.

[Eric Walch]

Code: Select all

[general.error.inconsistentState]: ***** ERROR: status is STATUS_DOCKED, but dockedStation is nil; treating as not docked. This is an internal error, please report it.

I think this type of error is normally generated by a script, if you forgot to check again whether the player is still docked when you display a mission screen.

Or something of the like.

The error is not generated by script, but triggered by scripts when reading out the docked state of the player. In pre 1.74 it happened when reading the docked state on shipWillDockWithStation. That was fixed in 1.74 already.

This one was new for me. I now simply searched for all places were the status was set to DOCKED. All had an explicit station just before setting status to docked.

Two exceptions:
- buying a ship. But that page is only available when docked.
- pressing space on a mission screen. This should only be possible when docked in a station, but since 1.74 missionscreens were made possible in space. When I now test the docked state of the player in a missionScreenEnded handler after creating a mission screen while in flight, I get exactly the same error.

Code: Select all

[general.error.inconsistentState] PlayerEntity.m:8197: ***** ERROR: status is STATUS_DOCKED, but dockedStation is nil; treating as not docked. This is an internal error, please report it.

I don't know why the state is explicit set to DOCKED when pressing space in a mission screen (and not with missionscreens with choices). But probably to prevent something going wrong, so it is not a matter of just deleting that line.

I assume this happened with Switeck. Can you confirm you used such in-flight missionscreens, or do we have still other courses here?

[Switeck]

I was using the menus/displays of Flight Log 1.03.oxp and LongRangeScanner v0.2.oxp "in flight" (while not docked).

[Thargoid]

Flight log can have a mission screen exited by space-bar (if the log is empty).

However that is essentially only a display screen to inform of the fact (if there is anything in the log, then the screen changes and you have choices available), and missionScreenEnded isn't used at all. There are no checks on docking status, as this particular OXP doesn't care about that.

[Eric Walch]

I was using the menus/displays of Flight Log 1.03.oxp and LongRangeScanner v0.2.oxp "in flight" (while not docked).

LongRangeScanner was not triggering it because it always has choices and I was wondering witch one was responsible. If none, the bug could lie somewhere else. But I never downloaded flight log. And indeed, it was this one that triggered the exception.

..... and missionScreenEnded isn't used at all. There are no checks on docking status, as this particular OXP doesn't care about that.

Even when your oxp is not using missionScreenEnded, any other oxp is also getting a missionScreenEnded. And without this check for inconsistentState those oxps might conclude that the player is still docked. But, in this case I noticed that the code also hits internal checks for isDocked that triggers the error log.

Putting the player always in isDocked mode after ending a mission screen happened already in rev 209 (the first version of this file). Looking at that code I think that the missionscreen code was copied from the intro screen display and had nothing to do there. At some point it was removed in the mission screen with choices by Giles in a fix for repeating keys in the missionscreen choice.
At least I am now convinced that that line was not added to prevent an other bug and will remove it.