Equipment Storage OXP

[phkb]

As part of my work on the Ship Configuration OXP, I implemented a system where equipment and cargo could be offloaded from your ship and put into storage. Then, at a later time, the equipment could be reinstalled, and the cargo transferred back into your hold. This seemed like a good thing to have on its own (without the overhead Ship Configuration brings), so I pulled it out and made it to be an independent OXP.

The interface is fairly simple. There will be a "Storage facility management" item on the F4 screen. Inside, you'll see any equipment and cargo currently stored at this station. You can select those items and have them put back on your ship, or, if you prefer, sold. Equipment will be sold at 85% of the original price, cargo will be sold (if there is room in the current market) at the station's market rate.

You can switch the view to include equipment and cargo you have storage in all other storage facilities around the galaxy. When viewing an item stored remotely, aside from selling the item, you can elect to have it transferred to your current station, although there is a chance of the equipment/cargo being lost if the transfer ship is destroyed by pirates.

Equipment is storage at 1cr per item per day. Some equipment items, which are viewed as having minimal weight or space, are charged at 0.1cr per item per day. Cargo is charged at 1cr per ton per day.

If you're using Ship Configuration, after today's update, you'll need to install this OXP for it to continue working.

Comments and feedback welcome.

[phkb]

Forgot to mention, the storage facility is only available at main stations. Info can be viewed at others stations, but access to your stored equipment/cargo is only from the main station.

Detailed info available on the  wiki.

The OXP is available for download via the ingame manager.

[phkb]

Version 1.1 fixes the OXP name in the manifest file.

[Damocles Edge]

A thought occurred to me (which I am sure you have already thought about and mitigated for, but just wanted to check).
Could equipment storage be used in order to "cheat" smugglers oxp?
By that I mean could you bulk offload cargo into storage at a station where it is legal.
Travel a short distance to a system where said cargo is prohibited to import, call it up from storage and sell on without having to go through any customs checks?
I only ask this as the evil side of me is looking for a get rich quick tactic or at least quicker than my 5t adder cargo hold will allow

[phkb]

Could equipment storage be used in order to "cheat" smugglers oxp?

Yes, I did think of that! And mitigations are already in place. But please, feel free to give it a go and make sure I covered all the bases!

[Redspear]

This is something I'd considered in the past (for my own ship equipment oxp) but never had the time to work out an easy way to do it.
So thanks for making this a seperate oxp! I haven't tried it yet but it sounds very useful.

Good work once again phkb!

[dybal]

Greetings!

I recently upgraded my ship and used Equipment Storage to hold the equipment I wanted to transfer to the new ship (so I didn't have to buy it all again).

There were two items lost after recovery (that is, storage removed it from storage but afterwards the item was not installed in the ship)::

- whatever laser was recovered into a secondary LMSS position;
- shield cycler;

Some items that doe't make sense to store were stored to, like SHIP_VERSION_nn and SERVICE_LEVEL_nn.

Cheers,

Dybal

[phkb]

Thanks for the report. Looks like I have some exceptions to include. I'll report back shortly.

[phkb]

- shield cycler;

Well, apart from finding some bugs in Shield Cycler, I wasn't able to store any part of a shield cycler installed on a ship. This is because almost all of the Shield Cycler equipment items are set with "visible = false", which means by default the equipment storage process will ignore them. How were you able to store shield cycler equipment items? Is there another OXP (other than Shield Cycler Next v1.12.1 or Shield Cycler v1.12) that is doing shield cycling? Is it the Shield Equalizer from CommonSenseOTB's ShieldEqualizer+Capacitors OXP? Or something else?

[dybal]

- shield cycler;

Well, apart from finding some bugs in Shield Cycler, I wasn't able to store any part of a shield cycler installed on a ship. This is because almost all of the Shield Cycler equipment items are set with "visible = false", which means by default the equipment storage process will ignore them. How were you able to store shield cycler equipment items? Is there another OXP (other than Shield Cycler Next v1.12.1 or Shield Cycler v1.12) that is doing shield cycling? Is it the Shield Equalizer from CommonSenseOTB's ShieldEqualizer+Capacitors OXP? Or something else?

It has been a while, but I saved every step of the ship exchange into a different savefile, and I still got them

Looking into them, I see you are right, Shield Cycler wasn't stored (it stayed in the old ship, and I didn't notice - had not looked _into_ the before exchange savefiles, just the F5 status screen)... what was stored was EQ_SC_SC_REPAIR, and when I "reclaimed" it into the new ship it got confusing...

BTW, I can upload those savefiles if you want them.

[phkb]

I can upload those savefiles if you want them.

That would be very handy, actually!

[Milo]

Looks like 'i' should be 'idx' here.

Code: Select all

Exception: ReferenceError: i is not defined
    Active script: EquipmentStorage 1.4
    equipstorage.js, line 2266:
    			var spcwt = this.$cargoSpaceRequired(this.$getCommodityType(this._tfrCargo), this._storage[i].weight);

[phkb]

Version 1.5 has been released. In this version:

• Added Trail Detector item to override list, allowing it to be stored.
• Added Mining IFF Scanner Upgrade item to override list, allowing it to be stored.
• Added Rescue Stations equipment items to override list, allowing them to be stored.
• Fixed issue with Ship Configuration items (Fuel Scoops, Heat Shields and Fuel Injectors) that were not being assessed correctly in determining when an item was in use.
• Bug fixes.

[dybal]

Got something in my Latest.log:

Code: Select all

15:53:45.759 [script.javaScript.warning.ooliteDefined]: ----- JavaScript warning (EquipmentStorage 1.5): Unknown expansion key [equipment-none-to-store] in string.
15:53:45.759 [script.javaScript.warning.ooliteDefined]:       /home/dybal/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.phkb.EquipmentStorage.oxz/Scripts/equipstorage.js, line 594.
15:53:45.759 [script.javaScript.stackTrace]:  0 (equipstorage.js:594) $storeEquipment()
15:53:45.759 [script.javaScript.stackTrace]:     this: [Script "EquipmentStorage" version 1.5]
15:53:45.759 [script.javaScript.stackTrace]:     opts: undefined
15:53:45.759 [script.javaScript.stackTrace]:     def: undefined
15:53:45.759 [script.javaScript.stackTrace]:     end: undefined
15:53:45.759 [script.javaScript.stackTrace]:     maxpage: undefined
15:53:45.759 [script.javaScript.stackTrace]:     damage: false
15:53:45.759 [script.javaScript.stackTrace]:     key: "EQ_WEAPON_NONE"
15:53:45.759 [script.javaScript.stackTrace]:     section: ["Forward", "Aft", "Port", "Starboard", ... <8 items total>]
15:53:45.759 [script.javaScript.stackTrace]:     lmss: [Script "LMSS_Core" version 2.5]
15:53:45.759 [script.javaScript.stackTrace]:     j: undefined
15:53:45.760 [script.javaScript.stackTrace]:     loop: undefined
15:53:45.760 [script.javaScript.stackTrace]:     colr: undefined
15:53:45.760 [script.javaScript.stackTrace]:     lookup: undefined
15:53:45.760 [script.javaScript.stackTrace]:     zeroSpace: undefined
15:53:45.760 [script.javaScript.stackTrace]:     weight: undefined
15:53:45.760 [script.javaScript.stackTrace]:     space: undefined
15:53:45.760 [script.javaScript.stackTrace]:     item: [EquipmentInfo EQ_SHIP_VERSION_31 "Ship Version 3.1"]
15:53:45.760 [script.javaScript.stackTrace]:     i: 7
15:53:45.760 [script.javaScript.stackTrace]:     list: []
15:53:45.760 [script.javaScript.stackTrace]:     eq: [[EquipmentInfo EQ_SHIP_VERSION_31 "Ship Version 3.1"]]
15:53:45.760 [script.javaScript.stackTrace]:     addText: " "
15:53:45.760 [script.javaScript.stackTrace]:     enabled: true
15:53:45.760 [script.javaScript.stackTrace]:     pagesize: 20
15:53:45.760 [script.javaScript.stackTrace]:     itemcount: 0
15:53:45.760 [script.javaScript.stackTrace]:     curChoices: {...}
15:53:45.760 [script.javaScript.stackTrace]:     text: " ..."
15:53:45.760 [script.javaScript.stackTrace]:     spc: ""
15:53:45.760 [script.javaScript.stackTrace]:     interrupt: true
15:53:45.760 [script.javaScript.stackTrace]:     maxspace: 0
15:53:45.760 [script.javaScript.stackTrace]:     used: 0
15:53:45.760 [script.javaScript.stackTrace]:     stn: [Station "Coriolis Station" "Coriolis Station" position: (-127406, -11054.2, 662169) scanClass: CLASS_STATION status: STATUS_ACTIVE]
15:53:45.760 [script.javaScript.stackTrace]:     p: [PlayerShip "Fer-de-Lance" position: (-127406, -11054.2, 662169) scanClass: CLASS_PLAYER status: STATUS_DOCKED]
15:53:45.760 [script.javaScript.stackTrace]:     compare: function compare
15:53:45.760 [script.javaScript.stackTrace]:  1 (equipstorage.js:856) $storeEquipmentScreenHandler()
15:53:45.760 [script.javaScript.stackTrace]:     this: [Script "EquipmentStorage" version 1.5]
15:53:45.760 [script.javaScript.stackTrace]:     choice: "01_EQUIP-00~EQ_SCANNER_SHOW_MISSILE_TARGET"
15:53:45.760 [script.javaScript.stackTrace]:     msg: "Commander Solo,\n\nThanks for choosing to store your equipment with us at HOowards Storage World. This is to confirm that the following items were removed from your ship and transferred successfully int..."
15:53:45.760 [script.javaScript.stackTrace]:     cost: "This item will be stored here at a rate of 0.1 ₢ per day."
15:53:45.760 [script.javaScript.stackTrace]:     storeName: "HOowards Storage World"
15:53:45.760 [script.javaScript.stackTrace]:     email: [Script "EmailSystem" version 1.7.8]
15:53:45.760 [script.javaScript.stackTrace]:     ga: [Script "GalCopAdminServices" version 1.7.8]
15:53:45.760 [script.javaScript.stackTrace]:     bl: undefined
15:53:45.760 [script.javaScript.stackTrace]:     lmss: undefined
15:53:45.760 [script.javaScript.stackTrace]:     idx: 1
15:53:45.760 [script.javaScript.stackTrace]:     creds: undefined
15:53:45.760 [script.javaScript.stackTrace]:     lookup: null
15:53:45.760 [script.javaScript.stackTrace]:     dam: "EQUIPMENT_OK"
15:53:45.760 [script.javaScript.stackTrace]:     weight: 0
15:53:45.760 [script.javaScript.stackTrace]:     space: 0
15:53:45.760 [script.javaScript.stackTrace]:     info: [EquipmentInfo EQ_SCANNER_SHOW_MISSILE_TARGET "Scanner Targeting Enhancement"]
15:53:45.760 [script.javaScript.stackTrace]:     section: ""
15:53:45.760 [script.javaScript.stackTrace]:     item: "EQ_SCANNER_SHOW_MISSILE_TARGET"
15:53:45.760 [script.javaScript.stackTrace]:     stn: [Station "Coriolis Station" "Coriolis Station" position: (-127406, -11054.2, 662169) scanClass: CLASS_STATION status: STATUS_ACTIVE]
15:53:45.760 [script.javaScript.stackTrace]:     p: [PlayerShip "Fer-de-Lance" position: (-127406, -11054.2, 662169) scanClass: CLASS_PLAYER status: STATUS_DOCKED]

[phkb]

Version 1.8 has been released, which doesn't have anything new at the moment. But when New Cargoes 2.0 is released, this will be compatible with it.