More error checking needed in oolite-populator's _addHunterPack

Milo · Post by **Milo** » Mon Jul 06, 2020 12:12 am

20:00:03.916 [LogEvents] GlobalLog: will launch from Dodecahedron Station 31697 flying Cobra Mark IV 31487
20:00:04.006 [station.launchShip.failed] -[StationEntity fitsInDock:andLogNoFit:]: Cancelled launch for a Orca Class Destroyer with role hunter, as it is too large for the docking port of the <StationEntity 0x7166610>{"Dodecahedron Station" "Dodecahedron Station" position: (15349.5, -94337.7, 349507) scanClass: CLASS_STATION status: STATUS_ACTIVE}.
20:00:04.503 [script.javaScript.exception.unexpectedType] ReportJSError: ***** JavaScript exception (telescope 2.0): TypeError: hs[i] is null
20:00:04.503 [script.javaScript.exception.unexpectedType] ReportJSError:       Resources/Scripts/oolite-populator.js, line 1667.

I'm not sure why telescope 2.0 is shown there, it doesn't set up any populators as far as I know. Regardless, the populator function was trying to launch some hunters and the code doesn't check for the possibility of failure there (which, as shown in the log immediately preceding the error, can occur if the ship selected for the role isn't able to fit in the dock).