Using "5" in a save game filename

[phkb]

If I press the number "5" when entering a save game filename, the view switches to the F5 screen. No other numbers do this.

[Cody]

Seems okay here... which version of Oolite and which OS are you running?

[phkb]

Oh, that's odd. OS is Windows 8.1, Oolite 1.80 64bit.

[phkb]

Just tried a new game with "Strict Mode" on, and same issue. So that should eliminate any OXP issues I would think.

[another_commander]

Are you using the 5 key on the numbers row or the 5 key on the numeric keypad?

Edit: Bug replicated on Windows XP 32-bit.
Edit2: I am away from my laptop and cannot compile to check right now, but PlayerEntityControls.m, method -pollGuiScreenControlsWithFKeyAlias:, line 3213 reads

Code: Select all

if ([gameView isDown:gvFunctionKey5] || [gameView isDown:key_gui_screen_status])

All other listed cases in that method read something like

Code: Select all

if (([gameView isDown:gvFunctionKey6])||(fKeyAlias && [gameView isDown:key_gui_chart_screens]))

i.e. they contain a condition that fKeyAlias must be true. I believe the fix would be to just add the check also for the status screen case which is currently missing it, most likely a little ommission error.

[phkb]

Yes, using the number 5 key on the numbers row.

[another_commander]

This bug should now be fixed in trunk and for 1.80.1 bugfix branch. You can test the fix in tonight's nightly build. Thanks for the report.

[Keeper]

I'm reminded of Steven Wright's comedy routine about having a phone with no 5 on it.