Mea culpa!

General discussion for players of Oolite.

Moderators: another_commander, winston

Post Reply
User avatar
hiran
Theorethicist
Posts: 2056
Joined: Fri Mar 26, 2021 1:39 pm
Location: a parallel world I created for myself. Some call it a singularity...

Mea culpa!

Post by hiran »

I configured the Github workflow that builds our nice nightly releases to give them distinct names so we can host more than just one in parallel.
Then I figured out that the cleanup step I introduced would never get active since the if condition was written the wrong way.
https://github.com/OoliteProject/oolite ... l.yml#L275

Obviously I corrected that mistake, which triggered the next build as planned. But then something happened that I did not foresee. Here is a screenshot of the log output:

Image

Despite the cleanup step to be configured for removing old prereleases, it decided to delete releases. I do not understand why it did, and I can no longer find ouy why it did so since these builds are no longer available. They are deleted.

1) I deactivated the build step again. No more deletions will be carried out
2) I will need help restoring these versions
3) I will need help to understand why some of the versions still seem to be online. Were they deleted or were they not? How come only some are missing?

This definitely needs to be clarified before I'd activate automatic deletions again.
I am sorry for the inconvenience and happy for any support.
Sunshine - Moonlight - Good Times - Oolite
User avatar
hiran
Theorethicist
Posts: 2056
Joined: Fri Mar 26, 2021 1:39 pm
Location: a parallel world I created for myself. Some call it a singularity...

Re: Mea culpa!

Post by hiran »

To be a bit more precise:

- 1.77.1 was deleted, but it is still on Github
- 1.80 was deleted, but it is still on Github
- 1.80a was deleted, and I cannot find it on Gibhub
Sunshine - Moonlight - Good Times - Oolite
User avatar
Mauiby de Fug
---- E L I T E ----
---- E L I T E ----
Posts: 847
Joined: Tue Sep 07, 2010 2:23 pm

Re: Mea culpa!

Post by Mauiby de Fug »

Slight correction:
1.77.1 was deleted and is no longer on GitHub
1.77.1a is still there and can be downloaded from GitHub
1.80 was deleted and is no longer on GitHub
1.80a was deleted and is no longer on GitHub
1.80b is still there and can be downloaded from Github

Looking at the oolite tags using the wayback machine shows that those that were deleted had, at the time of recording, the pre-release tag, which is not present on the others. And makes sense, since they were superseded by the later versions a and or b. If this was still the case, then arguably the workflow did what it was supposed to, and deleted the oldest pre-releases. Whether they were meant to be tagged as pre-release and kept is a different question.

Full restoration if desired would be tricky. There is a tag corresponding to the commit, so it should be possible to checkout at that commit and then run our build process to re-generate the limited number of builds we currently make. Which could potentially be uploaded somewhere. I've never played around with releases on GitHub so I don't know how much can be done, but the GitHub documentation implies that they are editable. However, some of the other builds, the Mac ones especially, could be lost.

The question is whether this is worth doing, since we still have the most recent examples tagged of each version number.

Possible recommendation: before playing around with the next iteration of adding/deleting releases, it might be an idea for someone to download all the previously stored release artifacts as a backup in case something goes wrong. :)
User avatar
hiran
Theorethicist
Posts: 2056
Joined: Fri Mar 26, 2021 1:39 pm
Location: a parallel world I created for myself. Some call it a singularity...

Re: Mea culpa!

Post by hiran »

Mauiby de Fug wrote: Tue Oct 17, 2023 8:24 pm
Slight correction:
1.77.1 was deleted and is no longer on GitHub
1.77.1a is still there and can be downloaded from GitHub
1.80 was deleted and is no longer on GitHub
1.80a was deleted and is no longer on GitHub
1.80b is still there and can be downloaded from Github

Looking at the oolite tags using the wayback machine shows that those that were deleted had, at the time of recording, the pre-release tag, which is not present on the others. And makes sense, since they were superseded by the later versions a and or b. If this was still the case, then arguably the workflow did what it was supposed to, and deleted the oldest pre-releases. Whether they were meant to be tagged as pre-release and kept is a different question.
Thank you for that analysis. It may mean we did not really loose important builds.
Mauiby de Fug wrote: Tue Oct 17, 2023 8:24 pm
Possible recommendation: before playing around with the next iteration of adding/deleting releases, it might be an idea for someone to download all the previously stored release artifacts as a backup in case something goes wrong. :)
I like that procedure. It is easy to implement and really allows to restore if something else gets lost. :-)
Sunshine - Moonlight - Good Times - Oolite
User avatar
phkb
Impressively Grand Sub-Admiral
Impressively Grand Sub-Admiral
Posts: 4646
Joined: Tue Jan 21, 2014 10:37 pm
Location: Writing more OXPs, because the world needs more OXPs.

Re: Mea culpa!

Post by phkb »

User avatar
hiran
Theorethicist
Posts: 2056
Joined: Fri Mar 26, 2021 1:39 pm
Location: a parallel world I created for myself. Some call it a singularity...

Re: Mea culpa!

Post by hiran »

That link offers 1.82, 1.84, 1.86, 1.88 and 1.90 - none of which were deleted.
That link offers 1.77.1 and previous.

So we can use it to restore 1.77.1 - but as Maulby put it: We still have 1.77.1a, so it would be questionable if we want to offer 1.77.1 again.
Restoring prereleases would make absolutely no sense. Otherwise the whole idea of automatic cleanups would be broken.
Sunshine - Moonlight - Good Times - Oolite
User avatar
hiran
Theorethicist
Posts: 2056
Joined: Fri Mar 26, 2021 1:39 pm
Location: a parallel world I created for myself. Some call it a singularity...

Re: Mea culpa!

Post by hiran »

As I learned we did not have loss of our beloved releases. But I also noticed it may have been close.

Therefore - before activating it again - I'll build some script that can backup all releases and their attachements.
Last edited by hiran on Mon Nov 06, 2023 7:41 am, edited 1 time in total.
Sunshine - Moonlight - Good Times - Oolite
User avatar
hiran
Theorethicist
Posts: 2056
Joined: Fri Mar 26, 2021 1:39 pm
Location: a parallel world I created for myself. Some call it a singularity...

Re: Mea culpa!

Post by hiran »

I built the script that downloads a project's releases and their assets and ran it to have a backup.
Then I activated the cleanup step again, and it only removed the intended parts. :-)

So we are good now, and in future the amount of prereleases will not spill over.
Sunshine - Moonlight - Good Times - Oolite
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6552
Joined: Wed Feb 28, 2007 7:54 am

Re: Mea culpa!

Post by another_commander »

Image

Who is cube?
User avatar
hiran
Theorethicist
Posts: 2056
Joined: Fri Mar 26, 2021 1:39 pm
Location: a parallel world I created for myself. Some call it a singularity...

Re: Mea culpa!

Post by hiran »

another_commander wrote: Mon Nov 06, 2023 7:58 am
Image

Who is cube?
It could have been anyone.

Code: Select all

git config --global user.name "Mona Lisa"
Sunshine - Moonlight - Good Times - Oolite
User avatar
phkb
Impressively Grand Sub-Admiral
Impressively Grand Sub-Admiral
Posts: 4646
Joined: Tue Jan 21, 2014 10:37 pm
Location: Writing more OXPs, because the world needs more OXPs.

Re: Mea culpa!

Post by phkb »

Yep. Anyone.

Image

Well, that's now squared away!
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6552
Joined: Wed Feb 28, 2007 7:54 am

Re: Mea culpa!

Post by another_commander »

OK cool, for a moment I thought we had an unauthorized repo access. Carry on.
User avatar
Cholmondely
Archivist
Archivist
Posts: 4998
Joined: Tue Jul 07, 2020 11:00 am
Location: The Delightful Domains of His Most Britannic Majesty (industrial? agricultural? mainly anything?)
Contact:

Re: Mea culpa!

Post by Cholmondely »

Just stumbled across this: Github: Backup the Berlios

Oolite was on Berlios before moving to GitHub
Comments wanted:
Missing OXPs? What do you think is missing?
Lore: The economics of ship building How many built for Aronar?
Lore: The Space Traders Flight Training Manual: Cowell & MgRath Do you agree with Redspear?
User avatar
hiran
Theorethicist
Posts: 2056
Joined: Fri Mar 26, 2021 1:39 pm
Location: a parallel world I created for myself. Some call it a singularity...

Re: Mea culpa!

Post by hiran »

Cholmondely wrote: Sat Dec 09, 2023 7:42 pm
Just stumbled across this: Github: Backup the Berlios

Oolite was on Berlios before moving to GitHub
That project has 5000+ repositories!
:shock: :shock: :shock:
Sunshine - Moonlight - Good Times - Oolite
Post Reply