Search found 11 matches

by bmaxa
Sun Nov 09, 2008 7:51 pm
Forum: Testing and Bug reports
Topic: Crashes with 1.72 on mac
Replies: 16
Views: 3352

Further investigating this (pretty difficult to follow through java script lib code), js_NumberToString is called after VectorDistanceTo, but I can;t see how crash is related to oolite code in this function as context is not touched and this lib function just passes buffer (from local stack) which w...
by bmaxa
Sun Nov 09, 2008 7:42 am
Forum: Testing and Bug reports
Topic: Crashes with 1.72 on mac
Replies: 16
Views: 3352

Just one question. As I see js_NumberToString is called in this case only when call is made through debug console and your crash happened in java script lib during JS_CallFunction (which is also in java script lib), before even getting to oolite distance function, from doEvent:withArguments oolite f...
by bmaxa
Sat Nov 08, 2008 12:39 am
Forum: Testing and Bug reports
Topic: 1.72 Freeze with conditions shipdata + system.legacy_add...
Replies: 10
Views: 2322

I'm sorry to bother again but bug is not cleared out with just if condition in removeObject. Other part of bug is in shipKey = [registry randomShipKeyForRole:role]; because it will call randomObject alright, but on other set, which does not guarantees that all object will come out eventualy as there...
by bmaxa
Fri Nov 07, 2008 6:26 pm
Forum: Testing and Bug reports
Topic: Crashes with 1.72 on mac
Replies: 16
Views: 3352

Hm, distanceTo uses JS_ValueToNumber and JS_NewDoubleValue,
which does not use js_NumberToString, but I have linux version.

Greets, Branimir.
by bmaxa
Fri Nov 07, 2008 5:27 pm
Forum: Testing and Bug reports
Topic: 1.72 Freeze with conditions shipdata + system.legacy_add...
Replies: 10
Views: 2322

I have returned method name to count and is decreasing anyway,
you are absolutely right. Seems that I first changed method name
to countPS then commented out line ;)

Greets, Branimir.
by bmaxa
Fri Nov 07, 2008 5:12 pm
Forum: Testing and Bug reports
Topic: 1.72 Freeze with conditions shipdata + system.legacy_add...
Replies: 10
Views: 2322

Thank you I will try my best. Another thing is I'm compiling on ubuntu 8.10 amd64 and got these warnings about pset count not used from OOMutableSet but from NSArray as methods have same name? I can swear that count was not decreased before I changed name count to countPS, though perhaps I'm wrong. ...
by bmaxa
Fri Nov 07, 2008 4:28 pm
Forum: Testing and Bug reports
Topic: 1.72 Freeze with conditions shipdata + system.legacy_add...
Replies: 10
Views: 2322

Bug solved

There are few problems in universe.m and probabilitySet. First method count for pset was used in nsarray not MutableProbabilitySet returnig incorrect value, and other thing is method removeObject from ConcreteMutableProbabilitySet never removed object as condition was if(object != nil)return. So, if...
by bmaxa
Thu Nov 06, 2008 7:41 pm
Forum: Testing and Bug reports
Topic: weapon_position_foo still broken in 1.72
Replies: 5
Views: 1082

Sorry that was quick ,didn;t work as you say as we can;t simply add to position (also relatively changes laser positon while flying), but this solution seems to work: Vector vo1 = vector_multiply_scalar(v_forward, offset.z); Vector vo2 = vector_multiply_scalar(v_right, offset.x); Vector vo3 = vector...
by bmaxa
Thu Nov 06, 2008 6:13 pm
Forum: Testing and Bug reports
Topic: small bug when charging for fuel v 1.72, and fuel capacity
Replies: 6
Views: 2368

Thank you all, I'm really hooked to this game ;)
by bmaxa
Thu Nov 06, 2008 6:12 pm
Forum: Testing and Bug reports
Topic: weapon_position_foo still broken in 1.72
Replies: 5
Views: 1082

This is easy to fix. Currently I can't see that weapon offset is used at all ;) Put simply position.x += offset.x; position.y += offset.y; position.z += offset.z; // just three lines in front of orientation = [ship normalOrientation]; Vector v_up = vector_up_from_quaternion(orientation); Vector v_fo...
by bmaxa
Thu Nov 06, 2008 2:29 pm
Forum: Testing and Bug reports
Topic: small bug when charging for fuel v 1.72, and fuel capacity
Replies: 6
Views: 2368

small bug when charging for fuel v 1.72, and fuel capacity

I have checkouted svn from maintenance 1.72 dir and found this: this is how it should be: if ([eq_key isEqual:@"EQ_FUEL"]) { // change order credits -= ([self fuelCapacity] - [self fuel]) * price_per_unit; fuel = [self fuelCapacity]; [self setGuiToEquipShipScreen:-1:-1]; return YES; } in o...